Skip to content
This repository has been archived by the owner on Mar 17, 2021. It is now read-only.

Fix compatibility tests #1647

Merged

Conversation

ScrewTSW
Copy link
Member

@ScrewTSW ScrewTSW commented Oct 8, 2019

What does this PR do?

This pull request fixes compatibility tests logic and allows them to run once again.

What issues does this PR fix or reference?

https://github.com/redhat-developer/che-functional-tests/issues/448
#936

How have you tested this PR?

manual testing on modified prcheck script
#1629

@centos-ci
Copy link
Collaborator

Copy link
Collaborator

@Katka92 Katka92 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please save all results of "$?" before you do checks, echos etc. to be sure that right value is used.

.ci/cico_rhche_compatibility_test.sh Outdated Show resolved Hide resolved
.ci/cico_rhche_compatibility_test.sh Outdated Show resolved Hide resolved
.ci/cico_rhche_compatibility_test.sh Outdated Show resolved Hide resolved
.ci/cico_rhche_compatibility_test.sh Outdated Show resolved Hide resolved
.ci/cico_rhche_compatibility_test.sh Outdated Show resolved Hide resolved
.ci/cico_rhche_compatibility_test.sh Outdated Show resolved Hide resolved
.ci/cico_rhche_compatibility_test.sh Outdated Show resolved Hide resolved
.ci/cico_rhche_compatibility_test.sh Outdated Show resolved Hide resolved
.ci/cico_rhche_compatibility_test.sh Show resolved Hide resolved
@ScrewTSW ScrewTSW force-pushed the feature-fix-compatibility-tests branch from eebea44 to 043f81e Compare October 8, 2019 12:18
.ci/cico_rhche_compatibility_test.sh Outdated Show resolved Hide resolved
Copy link
Collaborator

@amisevsk amisevsk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

.ci/cico_rhche_compatibility_test.sh Outdated Show resolved Hide resolved
.ci/cico_rhche_compatibility_test.sh Outdated Show resolved Hide resolved
.ci/cico_rhche_compatibility_test.sh Show resolved Hide resolved
.ci/cico_rhche_compatibility_test.sh Outdated Show resolved Hide resolved
@ScrewTSW ScrewTSW force-pushed the feature-fix-compatibility-tests branch 4 times, most recently from 0e8bf2d to 475a8a5 Compare October 9, 2019 13:16
@ScrewTSW ScrewTSW changed the title Fix compatibility tests [WIP] Fix compatibility tests Oct 9, 2019
@ScrewTSW ScrewTSW force-pushed the feature-fix-compatibility-tests branch from 475a8a5 to 95737ac Compare October 9, 2019 14:24
@ScrewTSW
Copy link
Member Author

ScrewTSW commented Oct 9, 2019

[test]

@centos-ci
Copy link
Collaborator

@ScrewTSW ScrewTSW force-pushed the feature-fix-compatibility-tests branch from 95737ac to 7e8d006 Compare October 10, 2019 08:37
@ScrewTSW ScrewTSW changed the title [WIP] Fix compatibility tests Fix compatibility tests Oct 10, 2019
@ScrewTSW
Copy link
Member Author

[test]

@redhat-developer redhat-developer deleted a comment from centos-ci Oct 10, 2019
@redhat-developer redhat-developer deleted a comment from centos-ci Oct 10, 2019
@redhat-developer redhat-developer deleted a comment from centos-ci Oct 10, 2019
@redhat-developer redhat-developer deleted a comment from centos-ci Oct 10, 2019
@redhat-developer redhat-developer deleted a comment from centos-ci Oct 10, 2019
@redhat-developer redhat-developer deleted a comment from centos-ci Oct 10, 2019
@redhat-developer redhat-developer deleted a comment from centos-ci Oct 10, 2019
@redhat-developer redhat-developer deleted a comment from centos-ci Oct 10, 2019
@centos-ci
Copy link
Collaborator

@ScrewTSW
Copy link
Member Author

[test]

echo $return_code > compatibility_status
}

<<<<<<< HEAD
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Merge conflict, needs to be fixed...

@centos-ci
Copy link
Collaborator

@ScrewTSW ScrewTSW force-pushed the feature-fix-compatibility-tests branch from 7e8d006 to cfad53c Compare October 11, 2019 09:36
@centos-ci
Copy link
Collaborator

@ScrewTSW
Copy link
Member Author

[test]

@centos-ci
Copy link
Collaborator

@Katka92
Copy link
Collaborator

Katka92 commented Oct 14, 2019

[test]

@centos-ci
Copy link
Collaborator

@ScrewTSW ScrewTSW merged commit f6f6c49 into redhat-developer:master Oct 14, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants