This repository has been archived by the owner on Mar 17, 2021. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 51
Fix compatibility tests #1647
Merged
ScrewTSW
merged 3 commits into
redhat-developer:master
from
ScrewTSW:feature-fix-compatibility-tests
Oct 14, 2019
Merged
Fix compatibility tests #1647
ScrewTSW
merged 3 commits into
redhat-developer:master
from
ScrewTSW:feature-fix-compatibility-tests
Oct 14, 2019
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ScrewTSW
requested review from
Katka92,
rhopp,
tomgeorge,
amisevsk,
davidfestal and
ibuziuk
October 8, 2019 10:11
@ScrewTSW PR check [build 1877] failed.Depending on failure reason, the artifacts or deployment may not be present. |
Katka92
suggested changes
Oct 8, 2019
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please save all results of "$?" before you do checks, echos etc. to be sure that right value is used.
ScrewTSW
force-pushed
the
feature-fix-compatibility-tests
branch
from
October 8, 2019 12:18
eebea44
to
043f81e
Compare
Katka92
approved these changes
Oct 8, 2019
amisevsk
approved these changes
Oct 8, 2019
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
ScrewTSW
force-pushed
the
feature-fix-compatibility-tests
branch
4 times, most recently
from
October 9, 2019 13:16
0e8bf2d
to
475a8a5
Compare
ScrewTSW
force-pushed
the
feature-fix-compatibility-tests
branch
from
October 9, 2019 14:24
475a8a5
to
95737ac
Compare
[test] |
@ScrewTSW PR check [build 1889] failed.Depending on failure reason, the artifacts or deployment may not be present. |
ScrewTSW
force-pushed
the
feature-fix-compatibility-tests
branch
from
October 10, 2019 08:37
95737ac
to
7e8d006
Compare
[test] |
@ScrewTSW PR check [build 1895] failed.Depending on failure reason, the artifacts or deployment may not be present. |
[test] |
Katka92
suggested changes
Oct 11, 2019
.ci/cico_rhche_compatibility_test.sh
Outdated
echo $return_code > compatibility_status | ||
} | ||
|
||
<<<<<<< HEAD |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Merge conflict, needs to be fixed...
@ScrewTSW PR check [build 1897] failed.Depending on failure reason, the artifacts or deployment may not be present. |
ScrewTSW
force-pushed
the
feature-fix-compatibility-tests
branch
from
October 11, 2019 09:36
7e8d006
to
cfad53c
Compare
@ScrewTSW PR check [build 1898] failed.Depending on failure reason, the artifacts or deployment may not be present. |
[test] |
@ScrewTSW PR check [build 1899] failed.Depending on failure reason, the artifacts or deployment may not be present. |
Katka92
approved these changes
Oct 11, 2019
[test] |
@ScrewTSW RH-Che [build 1900] has been successfully deployed and tested.deployment: http://rhche-prcheck-1647.devtools-dev.ext.devshift.net |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
This pull request fixes compatibility tests logic and allows them to run once again.
What issues does this PR fix or reference?
https://github.com/redhat-developer/che-functional-tests/issues/448
#936
How have you tested this PR?
manual testing on modified prcheck script
#1629