Remove usage of kube-rbac-proxy and switch to the built-in WithAuthenticationAndAuthorization filter instead
#338
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rm3l
force-pushed
the
RHIDP-4236--remove-kube-rbac-proxy-and-use-WithAuthenticationAndAuthorization-instead
branch
from
5f9d5fd to
bed266f
Compare
rm3l
force-pushed
the
RHIDP-4236--remove-kube-rbac-proxy-and-use-WithAuthenticationAndAuthorization-instead
branch
from
bed266f to
378f723
Compare
rm3l
changed the title
kube-rbac-proxy and switch to the built-in WithAuthenticationAndAuthorization filter insteadkube-rbac-proxy and switch to the built-in WithAuthenticationAndAuthorization filter instead
rm3l
force-pushed
the
RHIDP-4236--remove-kube-rbac-proxy-and-use-WithAuthenticationAndAuthorization-instead
branch
from
2f3c58d to
8195a4e
Compare
rm3l
force-pushed
the
RHIDP-4236--remove-kube-rbac-proxy-and-use-WithAuthenticationAndAuthorization-instead
branch
from
8195a4e to
d4fdab7
Compare
rm3l
changed the title
kube-rbac-proxy and switch to the built-in WithAuthenticationAndAuthorization filter insteadkube-rbac-proxy and switch to the built-in WithAuthenticationAndAuthorization filter instead
nickboldt
approved these changes
Oct 16, 2024
gazarenkov
reviewed
Oct 16, 2024
gazarenkov
reviewed
Oct 16, 2024
…dAuthorization` filter This is enabled only if `--metrics-over-https` is enabled, which is done to avoid passing service account tokens over HTTP. Metrics serving over HTTPS is disabled by default (when running the operator locally), but enabled when deployed either with or without OLM. Ref: https://pkg.go.dev/sigs.k8s.io/controller-runtime/pkg/metrics/filters#WithAuthenticationAndAuthorization
rm3l
force-pushed
the
RHIDP-4236--remove-kube-rbac-proxy-and-use-WithAuthenticationAndAuthorization-instead
branch
from
d4fdab7 to
430941d
Compare
|
New changes are detected. LGTM label has been removed. |
|
Rebased and forced-push to fix Git conflicts reported. |
gazarenkov
approved these changes
Oct 17, 2024
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: gazarenkov, nickboldt The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
rm3l
deleted the
RHIDP-4236--remove-kube-rbac-proxy-and-use-WithAuthenticationAndAuthorization-instead
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This removes all usage of the
kube-rbac-proxysidecar container, which was used to protect the/metricsendpoint exposed by the controller. This ensured that only authorized users and service accounts could access potentially sensitive metrics data.Instead, it is now recommended to leverage the built-in
WithAuthenticationAndAuthorizationfilter which provides a similar authn/authz protection of this endpoint but without the need for an extra container.More context in kubernetes-sigs/controller-runtime#2073 and https://book.kubebuilder.io/reference/metrics#how-the-metrics-endpoint-can-be-protected-
Which issue(s) does this PR fix or relate to
PR acceptance criteria
rhdh-operator.clusterserviceversion.yamlfile accordinglyHow to test changes / Special notes to the reviewer
From this PR: