Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Show server tasks in terminal #1153

Merged
merged 2 commits into from
Nov 25, 2019

Conversation

akaroml
Copy link
Contributor

@akaroml akaroml commented Nov 20, 2019

Signed-off-by: Rome Li rome.li@microsoft.com

Depends on: eclipse-jdtls/eclipse.jdt.ls#1280

Signed-off-by: Rome Li <rome.li@microsoft.com>
src/commands.ts Outdated Show resolved Hide resolved
src/serverTasks.ts Show resolved Hide resolved
src/serverTasks.ts Outdated Show resolved Hide resolved
Signed-off-by: Rome Li <rome.li@microsoft.com>
@akaroml
Copy link
Contributor Author

akaroml commented Nov 25, 2019

ping... @fbricon

@fbricon fbricon merged commit bb55be7 into redhat-developer:master Nov 25, 2019
@fbricon
Copy link
Collaborator

fbricon commented Nov 25, 2019

Nice job @akaroml !

@fbricon fbricon added this to the End November 2019 milestone Nov 25, 2019
@jclingan
Copy link

jclingan commented Dec 5, 2019

This feature creates a new terminal window by default. As a Java developer, why should I care about this? It is providing me all kinds of info that is not relevant to the project I am working on. If I set java.progressReports.enabled=false to stop the window creation, the terminal is still created but with no content. How can I prevent this terminal window when working on Java projects?

@jclingan
Copy link

jclingan commented Dec 5, 2019

When I "File->Add Folder to Workspace" for the first time to add a Java project, an untitled workspace is created and vscode tries to create a second instance of the server status window. This results in the attached error dialog. Note that "frontend" is the first java project, and "backend" is the second project that was added to the workspace, causing the error.

Java_Overview_—_Untitled__Workspace_

@akaroml
Copy link
Contributor Author

akaroml commented Dec 5, 2019

@jclingan ack. I can reproduce this issue. Will improve the support for multi-root workspace. Thanks for reporting.

@jclingan
Copy link

jclingan commented Dec 6, 2019

Thanks @akaroml !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants