workspace/notify notification creates no vscode command as expected #1369
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
angelozerr
force-pushed
the
workspace/notidy/onNotification
branch
from
29d52cc
to
d670f6a
Compare
fbricon
reviewed
Apr 6, 2020
|
@testforstephen @yaohaizh @jdneo please check this is compatible with vscode-java-debug, as you guys introduced it. |
angelozerr
force-pushed
the
workspace/notidy/onNotification
branch
from
d670f6a
to
3a1b4a8
Compare
Fixes redhat-developer#1367 Signed-off-by: azerr <azerr@redhat.com>
|
See microsoft/vscode-java-test#260 and https://github.com/microsoft/vscode-java-test/pull/309/files, Test runner is consuming this api. @jdneo Could you verify whether this break the test runner? |
|
The usage of |
testforstephen
approved these changes
Apr 7, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
workspace/notify notification creates no vscode command as expected
Fixes #1367
Signed-off-by: azerr azerr@redhat.com