Update language-client to 8.1.0 #2377

CsCherrYY · 2022-03-24T02:29:43Z

This PR is a part of #2376, to reduce the complexity of that PR. Type Hierarchy support has been introduced since language-client 8.0.0-next.4 so we should update this dependency, the language-client version requires vscode 1.61.0 for compiling, so I update this dependency as well.

for notification part: see https://github.com/microsoft/vscode-languageserver-node#3170-next-protocol-800-next-json-rpc-800-next-client-and-800-next-server, now all sendNotification methods will return a promise.

This update is incompatible with current Theia. see: eclipse-theia/theia#10993

src/extension.ts

src/hoverAction.ts

src/extension.ts

src/standardLanguageClient.ts

Eskibear

LGTM.

rgrunber · 2022-05-26T14:06:43Z

I ran into a problem updating to the language client to 8.0.1 in vscode-xml, and I suspect it'll be the same here. The extension will break on Theia.

Note: Node 14 needs to be used as with 12, I ran into SyntaxError: Unexpected Token '?'. (nullish coalescing issue).
Afterwards I ran into :

2022-05-26T13:34:36.203Z root INFO [hosted-plugin: 9987] PLUGIN_HOST(9987): PluginManagerExtImpl/loadPlugin(/home/rgrunber/.theia/extensions/vscode-xml-0.21.0.vsix/extension/dist/extension)
2022-05-26T13:34:36.257Z root ERROR [hosted-plugin: 9987] Activating extension 'XML' failed: TypeError: Class extends value undefined is not a constructor or null
    at Object.1365 (/home/rgrunber/.theia/extensions/vscode-xml-0.21.0.vsix/extension/dist/extension.js:2:447499)
    at n (/home/rgrunber/.theia/extensions/vscode-xml-0.21.0.vsix/extension/dist/extension.js:2:655557)
    at Object.71 (/home/rgrunber/.theia/extensions/vscode-xml-0.21.0.vsix/extension/dist/extension.js:2:340748)
    at n (/home/rgrunber/.theia/extensions/vscode-xml-0.21.0.vsix/extension/dist/extension.js:2:655557)
    at Object.4384 (/home/rgrunber/.theia/extensions/vscode-xml-0.21.0.vsix/extension/dist/extension.js:2:307797)
    at n (/home/rgrunber/.theia/extensions/vscode-xml-0.21.0.vsix/extension/dist/extension.js:2:655557)
    at Object.2850 (/home/rgrunber/.theia/extensions/vscode-xml-0.21.0.vsix/extension/dist/extension.js:2:481672)
    at n (/home/rgrunber/.theia/extensions/vscode-xml-0.21.0.vsix/extension/dist/extension.js:2:655557)
    at Object.4060 (/home/rgrunber/.theia/extensions/vscode-xml-0.21.0.vsix/extension/dist/extension.js:2:251645)
    at n (/home/rgrunber/.theia/extensions/vscode-xml-0.21.0.vsix/extension/dist/extension.js:2:655557)

extension.js:2:447499 points to class ProtocolTypeHierarchyItem extends code.TypeHierarchyItem
extension.js:2:251645 points to const vscode_languageclient_1 = __webpack_require__(48);

If I'm understanding how the __webpack_require__ works, const vscode_languageclient_1 is in 47, which gets called at the very beginning by const xmlExtensionApiImplementation_1 = __webpack_require__(47); . This is from xmlExtensionApiImplementation.ts which originates in the vscode-xml sources.

So the act of referencing the language client causes TypeHierarchyItem to be referenced, which Theia does not support

CC'ing @fbricon , @testforstephen in case I'm missing an obvious way to work around this.

CsCherrYY · 2022-05-27T01:42:13Z

@rgrunber Yeah I had opened an issue here: eclipse-theia/theia#10993, it seems Theia should support the related types (e.g., TypeHierarchyItem).

rgrunber · 2022-10-25T13:37:42Z

We should re-investigate this soon. Once Theia releases, I'm hoping this will work. It seems they recently started supporting the Type Hierarchy API.

https://eclipse-theia.github.io/vscode-theia-comparator/status.html

CsCherrYY · 2022-10-28T02:03:45Z

it seems that Theia has released a new version 1.31.0 which supports TypeHierarchyItem: https://github.com/eclipse-theia/theia/blob/master/CHANGELOG.md#breaking_changes_1.31.0

I will update the PR these days.

rgrunber · 2022-10-28T14:16:19Z

I may have been a bit too optimistic. We will still need to wait for the end of the year to be able to make this change, but at least it will happen eventually :(

CsCherrYY · 2022-10-31T01:53:45Z

@rgrunber is there anything I miss about this change?

One concern is that we seem not to have a way to define the required Theia version in package.json, since only the newest Theia supports this API.

CsCherrYY · 2023-01-30T08:42:38Z

6842d55 updates the language client to newest 8.0.2. Comparing it with the former 8.0.0-next 4, the changes can be found also in https://github.com/microsoft/vscode-languageserver-node#3170-protocol-800-json-rpc-800-client-and-800-server:

removeal of onReady()
change of ErrorHandler

cc @rgrunber

CsCherrYY · 2023-02-07T08:01:49Z

maybe eclipse-jdtls/eclipse.jdt.ls#1790 is related. @rgrunber could you provide any comments?

CsCherrYY · 2023-02-13T03:10:28Z

@datho7561 It seems that if we disable the client capability shouldLanguageServerExitOnShutdown, the error notification will not appear and the syntax server can shutdown successfully. Could you help verify it?

@rgrunber If it's true, I guess language client 8+ has fixed what we patch in eclipse-jdtls/eclipse.jdt.ls#1790.

datho7561 · 2023-02-13T15:55:57Z

... if we disable the client capability shouldLanguageServerExitOnShutdown, the error notification will not appear and the syntax server can shutdown successfully

Yes, i think this is the right fix. This is what we did in redhat-developer/vscode-xml@825823c for vscode-xml

datho7561

After shouldLanguageServerExitOnShutdown is removed/set to false, I think this PR will be good

datho7561 · 2023-02-13T16:01:06Z

src/providerDispatcher.ts

@@ -99,10 +99,10 @@ function createDocumentSymbolProvider(): DocumentSymbolProvider {
 			}

 			if ((<any>symbolResponse[0]).containerName) {
-				return languageClient.protocol2CodeConverter.asSymbolInformations(<clientSymbolInformation[]>symbolResponse);
+				return await languageClient.protocol2CodeConverter.asSymbolInformations(<clientSymbolInformation[]>symbolResponse);


If the result of the protocol2CodeConverter is a Promise, I think you should be able to return the Promise without using await and it will do the same thing. (this isn't a big deal though).

jdneo · 2023-02-16T06:06:35Z

BTW, dose the new version of language client has native support of inlay hint? If yes, maybe we can remove https://github.com/redhat-developer/vscode-java/blob/master/src/inlayHintsProvider.ts and its related code.

CsCherrYY · 2023-02-17T01:49:10Z

@jdneo I guess the anwser is yes. See: https://github.com/microsoft/vscode-languageserver-node#3170-protocol-800-json-rpc-800-client-and-800-server inlay hint support is in the list here. I also find the related types in the language-client library.

CsCherrYY · 2023-02-17T01:51:02Z

it looks like vscode-languageclient version 8.1.0 is available, I'll take a look if we can directly update to this version.

Signed-off-by: Shi Chen <chenshi@microsoft.com>

rgrunber

Overall, looks fine (with the lsp4j 0.20.0 PR in JDT-LS). I tried out rename, codelens, inlay hints, type hierarchy as those seem to be more at risk for breakage. It all seems to work well. The syntax server shuts down on its own as well.

I did noticed : https://github.com/redhat-developer/vscode-java/actions/runs/4200047119/jobs/7285652596#step:9:13 . The build still passes. Is this safe ?

rgrunber · 2023-02-21T21:24:03Z

src/extension.ts

+						// https://github.com/redhat-developer/vscode-java/pull/2377#issuecomment-1427268344
+						shouldLanguageServerExitOnShutdown: false,


Yes, this was fixed in the language client release that supported 3.17. Original issue is at #1928 (comment) . There's no need to set it to false as that's the default value anyways on the server side. In fact, there's a good argument for getting rid of it entirely since it was really to handle some non-protocol behaviour.

Eskibear · 2023-02-22T02:22:27Z

The build still passes. Is this safe ?

@rgrunber
Probably we should upgrade version of typescript. See microsoft/TypeScript#1778 (comment)

rgrunber · 2023-02-22T13:54:34Z

Ok, then let's go ahead and update typescript here if that will fix it.

Signed-off-by: Shi Chen <chenshi@microsoft.com>

CsCherrYY · 2023-02-23T02:19:17Z

package.json

@@ -1397,7 +1397,7 @@
    "@types/glob": "5.0.30",
    "@types/lodash.findindex": "^4.6.6",
    "@types/mocha": "^5.2.5",
-    "@types/node": "^8.10.51",


Since VS Code has switched to node 16 since 1.66 (https://code.visualstudio.com/updates/v1_66#_nodemoduleversion-and-nodejs-api-update), let's update this deps as well. The update will resolve the following error:

node_modules/vscode-jsonrpc/lib/node/main.d.ts(8,37): error TS2307: Cannot find module 'worker_threads' or its corresponding type declarations.

Signed-off-by: Shi Chen <chenshi@microsoft.com>

CsCherrYY · 2023-02-23T02:27:52Z

@rgrunber it looks like that issue got resolved after updating typescript and node :)

CsCherrYY commented Mar 24, 2022

View reviewed changes

src/extension.ts Outdated Show resolved Hide resolved

CsCherrYY commented Mar 24, 2022

View reviewed changes

src/hoverAction.ts Outdated Show resolved Hide resolved

CsCherrYY commented Mar 24, 2022

View reviewed changes

src/extension.ts Outdated Show resolved Hide resolved

CsCherrYY mentioned this pull request Mar 24, 2022

Move Type Hierarchy implementation to LSP #2376

Open

Eskibear reviewed Mar 25, 2022

View reviewed changes

src/standardLanguageClient.ts Outdated Show resolved Hide resolved

github-actions bot added the has conflicts label Mar 30, 2022

CsCherrYY force-pushed the cs-typehierarchy-lsp branch from 2b356eb to 7d6fb9a Compare March 30, 2022 07:04

Eskibear approved these changes Mar 30, 2022

View reviewed changes

CsCherrYY mentioned this pull request Mar 31, 2022

March 2022 Endgame microsoft/vscode-java-pack#945

Closed

14 tasks

github-actions bot removed the has conflicts label Apr 5, 2022

rgrunber added the dependencies Pull requests that update a dependency file label May 26, 2022

rgrunber mentioned this pull request May 26, 2022

Move to vscode-languageclient 8.0.2 for Qute LS redhat-developer/vscode-quarkus#506

Merged

rgrunber linked an issue May 27, 2022 that may be closed by this pull request

Support vscode-languageclient@8.1.0 #2474

Closed

rgrunber mentioned this pull request May 27, 2022

Support vscode-languageclient@8.1.0 #2474

Closed

github-actions bot added the has conflicts label Jun 22, 2022

CsCherrYY mentioned this pull request Oct 27, 2022

Java(16777540): The type xxx cannot be resolved. It is indirectly referenced from required .class files microsoft/vscode-java-pack#1081

Open

24 tasks

CsCherrYY mentioned this pull request Nov 28, 2022

Update to newer LSP4J eclipse-jdtls/eclipse.jdt.ls#2348

Closed

rgrunber self-requested a review January 25, 2023 14:09

CsCherrYY mentioned this pull request Jan 30, 2023

Use LSP4J 0.20.0 eclipse-jdtls/eclipse.jdt.ls#2417

Merged

CsCherrYY force-pushed the cs-typehierarchy-lsp branch from 7d6fb9a to 9b1e44f Compare January 30, 2023 07:40

CsCherrYY changed the title ~~Update language-client to 8.0.0-next.4~~ Update language-client to 8.0.2 Jan 30, 2023

CsCherrYY force-pushed the cs-typehierarchy-lsp branch 2 times, most recently from 8e71654 to 6f6414d Compare January 31, 2023 03:11

github-actions bot added the has conflicts label Feb 9, 2023

CsCherrYY force-pushed the cs-typehierarchy-lsp branch from c5afa60 to c7455ae Compare February 13, 2023 05:22

datho7561 requested changes Feb 13, 2023

View reviewed changes

datho7561 self-requested a review February 14, 2023 13:56

github-actions bot removed the has conflicts label Feb 16, 2023

rgrunber added this to the Mid March 2023 milestone Feb 16, 2023

CsCherrYY added 3 commits February 17, 2023 10:05

update language client to 8.0.2

bc7ecfa

Signed-off-by: Shi Chen <chenshi@microsoft.com>

address comments

e6b0755

Signed-off-by: Shi Chen <chenshi@microsoft.com>

update language-client to 8.1.0

9c2074c

Signed-off-by: Shi Chen <chenshi@microsoft.com>

CsCherrYY force-pushed the cs-typehierarchy-lsp branch from 7c28e29 to 9c2074c Compare February 17, 2023 02:20

rgrunber reviewed Feb 21, 2023

View reviewed changes

github-actions bot added the has conflicts label Feb 22, 2023

CsCherrYY changed the title ~~Update language-client to 8.0.2~~ Update language-client to 8.1.0 Feb 22, 2023

Merge branch 'master' into cs-typehierarchy-lsp

6c034d8

github-actions bot removed the has conflicts label Feb 22, 2023

update deps

72619f2

Signed-off-by: Shi Chen <chenshi@microsoft.com>

CsCherrYY commented Feb 23, 2023

View reviewed changes

remove client capability

74abcaf

Signed-off-by: Shi Chen <chenshi@microsoft.com>

rgrunber merged commit 6572351 into redhat-developer:master Feb 23, 2023

CsCherrYY deleted the cs-typehierarchy-lsp branch February 23, 2023 04:27

rgrunber removed this from the Mid March 2023 milestone Mar 15, 2023

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Update language-client to 8.1.0 #2377

Update language-client to 8.1.0 #2377

CsCherrYY commented Mar 24, 2022 •

edited

Loading

Eskibear left a comment

rgrunber commented May 26, 2022

CsCherrYY commented May 27, 2022

rgrunber commented Oct 25, 2022

CsCherrYY commented Oct 28, 2022

rgrunber commented Oct 28, 2022

CsCherrYY commented Oct 31, 2022

CsCherrYY commented Jan 30, 2023 •

edited

Loading

CsCherrYY commented Feb 7, 2023

CsCherrYY commented Feb 13, 2023

datho7561 commented Feb 13, 2023

datho7561 left a comment

datho7561 Feb 13, 2023

jdneo commented Feb 16, 2023

CsCherrYY commented Feb 17, 2023

CsCherrYY commented Feb 17, 2023

rgrunber left a comment •

edited

Loading

rgrunber Feb 21, 2023

Eskibear commented Feb 22, 2023

rgrunber commented Feb 22, 2023

CsCherrYY Feb 23, 2023

CsCherrYY commented Feb 23, 2023

		// https://github.com/redhat-developer/vscode-java/pull/2377#issuecomment-1427268344
		shouldLanguageServerExitOnShutdown: false,

Update language-client to 8.1.0 #2377

Update language-client to 8.1.0 #2377

Conversation

CsCherrYY commented Mar 24, 2022 • edited Loading

Eskibear left a comment

Choose a reason for hiding this comment

rgrunber commented May 26, 2022

CsCherrYY commented May 27, 2022

rgrunber commented Oct 25, 2022

CsCherrYY commented Oct 28, 2022

rgrunber commented Oct 28, 2022

CsCherrYY commented Oct 31, 2022

CsCherrYY commented Jan 30, 2023 • edited Loading

CsCherrYY commented Feb 7, 2023

CsCherrYY commented Feb 13, 2023

datho7561 commented Feb 13, 2023

datho7561 left a comment

Choose a reason for hiding this comment

datho7561 Feb 13, 2023

Choose a reason for hiding this comment

jdneo commented Feb 16, 2023

CsCherrYY commented Feb 17, 2023

CsCherrYY commented Feb 17, 2023

rgrunber left a comment • edited Loading

Choose a reason for hiding this comment

rgrunber Feb 21, 2023

Choose a reason for hiding this comment

Eskibear commented Feb 22, 2023

rgrunber commented Feb 22, 2023

CsCherrYY Feb 23, 2023

Choose a reason for hiding this comment

CsCherrYY commented Feb 23, 2023

CsCherrYY commented Mar 24, 2022 •

edited

Loading

CsCherrYY commented Jan 30, 2023 •

edited

Loading

rgrunber left a comment •

edited

Loading