Add a setting to control whether 'textEdit' of completion items can be resolved #3072
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… lazy-resolved Signed-off-by: Sheng Chen <sheche@microsoft.com>
jdneo
force-pushed
the
cs/textEditResolveFlag
branch
from
4fbd9e0
to
6cd77d2
Compare
testforstephen
approved these changes
Apr 20, 2023
Signed-off-by: sheche <sheche@microsoft.com>
gayanper
pushed a commit
to gayanper/vscode-java
that referenced
this pull request
May 27, 2023
…e resolved (redhat-developer#3072) * Add a setting to control whether 'textEdit' of completion item can be lazy-resolved Signed-off-by: Sheng Chen <sheche@microsoft.com>
gayanper
pushed a commit
to gayanper/vscode-java
that referenced
this pull request
May 30, 2023
…e resolved (redhat-developer#3072) * Add a setting to control whether 'textEdit' of completion item can be lazy-resolved Signed-off-by: Sheng Chen <sheche@microsoft.com>
gayanper
pushed a commit
to gayanper/vscode-java
that referenced
this pull request
Jun 14, 2023
…e resolved (redhat-developer#3072) * Add a setting to control whether 'textEdit' of completion item can be lazy-resolved Signed-off-by: Sheng Chen <sheche@microsoft.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use a setting to control whether to append
textEditto theresolveSupportof completion.This allows us to have a fallback when lazy-resolving textEdit no longer works in the future, while still comply with the protocol.
Requires eclipse-jdtls/eclipse.jdt.ls#2600