Fix review changes

redhat-developer · Dec 7, 2019 · 6979842 · 6979842
1 parent 922c693
commit 6979842
Show file tree

Hide file tree

Showing 5 changed files with 6 additions and 6 deletions.
diff --git a/src/extension.ts b/src/extension.ts
@@ -38,7 +38,7 @@ export async function activate(context: vscode.ExtensionContext) {
         vscode.commands.registerCommand('tekton.pipelinerun.list', (context) => execute(PipelineRun.list, context)),
         vscode.commands.registerCommand('tekton.pipelinerun.describe', (context) => execute(PipelineRun.describe, context)),
         vscode.commands.registerCommand('tekton.pipelinerun.logs', (context) => execute(PipelineRun.logs, context)),
-        vscode.commands.registerCommand('tekton.pipelinerun.followLogs', (context) => execute(PipelineRun.followLog, context)),
+        vscode.commands.registerCommand('tekton.pipelinerun.followLogs', (context) => execute(PipelineRun.followLogs, context)),
         vscode.commands.registerCommand('tekton.pipelinerun.cancel', (context) => execute(PipelineRun.cancel, context)),
         vscode.commands.registerCommand('tekton.pipelinerun.delete', (context) => execute(PipelineRun.delete, context)),
         vscode.commands.registerCommand('tekton.task.start', (context) => execute(Task.start, context)),
@@ -50,7 +50,7 @@ export async function activate(context: vscode.ExtensionContext) {
         vscode.commands.registerCommand('tekton.taskrun.list', (context) => execute(TaskRun.list, context)),
         vscode.commands.registerCommand('tekton.taskrun.listFromTask', (context) => execute(TaskRun.listFromTask, context)),
         vscode.commands.registerCommand('tekton.taskrun.logs', (context) => execute(TaskRun.logs, context)),
-        vscode.commands.registerCommand('tekton.taskrun.followLogs', (context) => execute(TaskRun.followLog, context)),
+        vscode.commands.registerCommand('tekton.taskrun.followLogs', (context) => execute(TaskRun.followLogs, context)),
        // vscode.commands.registerCommand('tekton.taskrun.cancel', (context) => execute(TaskRun.cancel, context)),
         vscode.commands.registerCommand('tekton.taskrun.delete', (context) => execute(TaskRun.delete, context)),
         vscode.commands.registerCommand('tekton.explorer.reportIssue', () => PipelineExplorer.reportIssue()),

diff --git a/src/tekton/pipelinerun.ts b/src/tekton/pipelinerun.ts
@@ -40,7 +40,7 @@ export class PipelineRun extends TektonItem {
         if (pipelinerun) { PipelineRun.tkn.executeInTerminal(Command.showPipelineRunLogs(pipelinerun.getName())); }
     }
 
-    static async followLog(pipelinerun: TektonNode): Promise<void> {
+    static async followLogs(pipelinerun: TektonNode): Promise<void> {
         PipelineRun.tkn.executeInTerminal(Command.showPipelineRunFollowLogs(pipelinerun.getName()));
     }
 

diff --git a/src/tekton/taskrun.ts b/src/tekton/taskrun.ts
@@ -20,7 +20,7 @@ export class TaskRun extends TektonItem {
         if (taskrun) { TaskRun.tkn.executeInTerminal(Command.showTaskRunLogs(taskrun.getName())); }
     }
 
-    static async followLog(taskrun: TektonNode): Promise<void> {
+    static async followLogs(taskrun: TektonNode): Promise<void> {
         TaskRun.tkn.executeInTerminal(Command.showTaskRunFollowLogs(taskrun.getName()));
     }
 

diff --git a/test/tekton/pipelinerun.test.ts b/test/tekton/pipelinerun.test.ts
@@ -119,7 +119,7 @@ suite('Tekton/PipelineRun', () => {
         suite('followLog', () => {
 
             test('followLog calls the correct tkn command in terminal', async () => {
-                await PipelineRun.followLog(pipelinerunItem);
+                await PipelineRun.followLogs(pipelinerunItem);
 
                 expect(termStub).calledOnceWith(Command.showPipelineRunFollowLogs(pipelinerunItem.getName()));
             });

diff --git a/test/tekton/taskrun.test.ts b/test/tekton/taskrun.test.ts
@@ -132,7 +132,7 @@ suite('Tekton/TaskRun', () => {
         suite('followLog', () => {
 
             test('followLog calls the correct tkn command in terminal', async () => {
-                await TaskRun.followLog(taskrunItem);
+                await TaskRun.followLogs(taskrunItem);
 
                 expect(termStub).calledOnceWith(Command.showTaskRunFollowLogs(taskrunItem.getName()));
             });