Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use condition name for 'Condition' node in pipeline run child nodes #277

Closed
evidolob opened this issue May 7, 2020 · 3 comments · Fixed by #292
Closed

Use condition name for 'Condition' node in pipeline run child nodes #277

evidolob opened this issue May 7, 2020 · 3 comments · Fixed by #292
Assignees
Labels
kind/bug Something isn't working size/S Denotes a PR that changes 10-29 lines, ignoring generated files. ui/ux issues related to user interface / user experience
Milestone

Comments

@evidolob
Copy link
Collaborator

evidolob commented May 7, 2020

Now if task has condition we add item in the tree with task name not with condition name:
Screenshot 2020-05-07 at 17 43 38

We need to use condition name for that tree item.

@evidolob evidolob added kind/bug Something isn't working ui/ux issues related to user interface / user experience labels May 7, 2020
@evidolob evidolob added this to the Sprint #184 milestone May 7, 2020
@evidolob evidolob self-assigned this May 13, 2020
@evidolob evidolob added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label May 13, 2020
@evidolob
Copy link
Collaborator Author

@siamaksade We are showing condition run as taskrun nodes, but intellij-tekton add condition run as child to taskrun, see redhat-developer/intellij-tekton#94
Should we alight with them?

@lstocchi
Copy link
Contributor

I just want to add that we display conditions in two different ways based on the position in the tree. The one Yevhen described, as children of a taskrun node under a pipelinerun node and as normal taskrun nodes under the taskruns root node.

We took this decision because we thought it would be clearer from a user perspective to understand which condition failed and what was the task it was related to when starting a pipeline, but we show them as normal taskrun nodes under taskrun root node because they are treated as taskruns in tekton.

BTW we are open to suggestion as well. If you find a better solution we are always ready to steal it from vscode ;) And also, if you need any other info, feel free to ask :)

@gorkem
Copy link
Collaborator

gorkem commented May 15, 2020

I was going to ask for this, @evidolob looks like you have beaten me to it. I think the way intellij-tekton shows conditions on a pipelinerun is more helpful, +1 to converge on that.

evidolob added a commit that referenced this issue May 20, 2020
Signed-off-by: Yevhen Vydolob <yvydolob@redhat.com>
evidolob added a commit that referenced this issue May 20, 2020
evidolob added a commit that referenced this issue May 20, 2020
evidolob added a commit that referenced this issue May 20, 2020
Signed-off-by: Yevhen Vydolob <yvydolob@redhat.com>
evidolob added a commit that referenced this issue May 25, 2020
* #277 show condition run as child for taskrun

Signed-off-by: Yevhen Vydolob <yvydolob@redhat.com>

* Fix all issues related to start and refreash tree

Signed-off-by: Yevhen Vydolob <yvydolob@redhat.com>

* remove unused variables

Signed-off-by: Yevhen Vydolob <yvydolob@redhat.com>

* add more descriptive message in case taskrun load error

Signed-off-by: Yevhen Vydolob <yvydolob@redhat.com>

* Use new state icons for some tree items

Signed-off-by: Yevhen Vydolob <yvydolob@redhat.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/bug Something isn't working size/S Denotes a PR that changes 10-29 lines, ignoring generated files. ui/ux issues related to user interface / user experience
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants