Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Limit number of pipelineruns and taskruns shown in tree through extension preference #79

Closed
dgolovin opened this issue Nov 7, 2019 · 4 comments
Assignees
Labels
enhancement New feature or request
Milestone

Comments

@dgolovin
Copy link
Contributor

dgolovin commented Nov 7, 2019

Would be good to have limit, because list can grow over time.

@dgolovin dgolovin added the enhancement New feature or request label Nov 7, 2019
@dgolovin dgolovin added this to the devex #175 milestone Nov 7, 2019
@dgolovin dgolovin self-assigned this Nov 7, 2019
@jeffmaury
Copy link
Member

Something I have in mind for the IntelliJ plugin: display the first n (5 ?) elements and if there are more, add a clickable More node after the last one. When click display the next n ones. But not sure tkn allows this kind of cursor mode. Maybe @joshuawilson can comment

@dgolovin dgolovin modified the milestones: devex #175, devex #176 Nov 27, 2019
@dgolovin dgolovin removed their assignment Dec 17, 2019
@dgolovin
Copy link
Contributor Author

@jeffmaury there is no cursor mode, just limit for how many records to fetch. It still possible to the way you suggested, but it would require reload whole node with increased --limit option.

@joshuawilson
Copy link
Member

What if you fetch more then you need, say 100. Then you display the first 5 or 10. There could be a more button or something that would display another 5 or 10. If you get to 70, then fetch another 100.

That is basic pagination.

@jeffmaury
Copy link
Member

The issue here is that the tkn client does not support pagination but only result limiting

@evidolob evidolob modified the milestones: devex #177, devex #178 Jan 8, 2020
evidolob added a commit that referenced this issue Jan 13, 2020
Signed-off-by: Yevhen Vydolob <yvydolob@redhat.com>
evidolob added a commit that referenced this issue Jan 14, 2020
* #79 limit number of pipelineruns and taskruns in tree
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

4 participants