Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add preview for pipeline tasks #160

Merged
merged 10 commits into from
Mar 2, 2020
Merged

Add preview for pipeline tasks #160

merged 10 commits into from
Mar 2, 2020

Conversation

evidolob
Copy link
Collaborator

@evidolob evidolob commented Feb 25, 2020

Fix: #150

This PR add Open Pipeline preview to the Side command in editor title bar, which open pipeline preview webview.

In webview used cytoscape with dagre plugin (to render DAG tree), JS lib to render pipeline task execution diagram

Current demo:
ezgif com-optimize

First diagram on the demo is equal to diagram from tekton documentation

Things to do:

  • Implement webview persistence, now all content lost when preview tab switched
  • Implement support of vscode theme switching
  • Update diagram on pipeline editing

Signed-off-by: Yevhen Vydolob <yvydolob@redhat.com>
@evidolob evidolob self-assigned this Feb 25, 2020
Signed-off-by: Yevhen Vydolob <yvydolob@redhat.com>
@codecov-io
Copy link

codecov-io commented Feb 25, 2020

Codecov Report

Merging #160 into master will increase coverage by 1.59%.
The diff coverage is 71.42%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #160      +/-   ##
==========================================
+ Coverage   71.68%   73.27%   +1.59%     
==========================================
  Files          33       33              
  Lines        1865     1860       -5     
  Branches      291      291              
==========================================
+ Hits         1337     1363      +26     
+ Misses        528      497      -31
Impacted Files Coverage Δ
src/pipeline/preview-manager.ts 26.66% <ø> (+3.8%) ⬆️
src/pipeline/pipeline-preview.ts 86.36% <100%> (+18.18%) ⬆️
src/extension.ts 88% <100%> (ø) ⬆️
src/pipeline/customTektonExplorer.ts 61.29% <50%> (ø) ⬆️
src/pipeline/pipelineExplorer.ts 57.77% <50%> (ø) ⬆️
src/pipeline/pipeline-graph.ts 96.42% <0%> (+78.57%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 884e721...289e18d. Read the comment docs.

@siamaksade
Copy link

cc @vdemeester @sthaha

@vdemeester
Copy link
Member

Nice ! 😻

Signed-off-by: Yevhen Vydolob <yvydolob@redhat.com>
Signed-off-by: Yevhen Vydolob <yvydolob@redhat.com>
@evidolob
Copy link
Collaborator Author

Update diagram preview on pipeline change in editor demo:
ezgif com-video-to-gif (3)
cc @siamaksade

@evidolob
Copy link
Collaborator Author

Theme switching demo:

ezgif com-video-to-gif (4)

@evidolob evidolob marked this pull request as ready for review February 27, 2020 15:07
Signed-off-by: Yevhen Vydolob <yvydolob@redhat.com>
Signed-off-by: Yevhen Vydolob <yvydolob@redhat.com>
Signed-off-by: Yevhen Vydolob <yvydolob@redhat.com>
@evidolob evidolob merged commit 72fe276 into master Mar 2, 2020
@evidolob evidolob deleted the pipeline-preview branch March 2, 2020 12:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add pipeline diagram preview
4 participants