Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added new icon in tree view resource #191

Merged
merged 3 commits into from
Mar 12, 2020

Conversation

sudhirverma
Copy link
Contributor

Screenshot 2020-03-09 at 3 18 59 PM

@codecov-io
Copy link

codecov-io commented Mar 9, 2020

Codecov Report

Merging #191 into master will increase coverage by 0.02%.
The diff coverage is 0%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #191      +/-   ##
==========================================
+ Coverage   73.41%   73.44%   +0.02%     
==========================================
  Files          33       33              
  Lines        1892     1894       +2     
  Branches      292      293       +1     
==========================================
+ Hits         1389     1391       +2     
  Misses        503      503
Impacted Files Coverage Δ
src/tkn.ts 77.46% <ø> (ø) ⬆️
src/pipeline/preview.ts 15.49% <0%> (ø) ⬆️
src/tools.ts 94.56% <0%> (+0.12%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0773a0e...e4aeddb. Read the comment docs.

Copy link
Collaborator

@evidolob evidolob left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

New images doesn't work for pipeline preview:

General look:
Screenshot 2020-03-10 at 12 33 46

But with zoom-in new icons become unreadable:
ezgif com-video-to-gif

Note: I use 'Tekton' svg as sample that other svg works fine

@evidolob
Copy link
Collaborator

Patch to test preview with new icons https://gist.github.com/evidolob/40a90c1bdd77dba72743d362b7ac0ac3

@sudhirverma
Copy link
Contributor Author

@evidolob & @siamaksade

Screen Recording 2020-03-11 at 3 38 38 PM

Copy link
Collaborator

@evidolob evidolob left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It works as expected.
Please delete unused resources(png/svg), to make repository clear

@evidolob
Copy link
Collaborator

@sudhirverma Please add icon description in README.md https://github.com/redhat-developer/vscode-tekton#icons-representation

@sudhirverma sudhirverma merged commit d109bcf into redhat-developer:master Mar 12, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants