Single click on icon will open yaml in editor #241
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sudhirverma
changed the title
|
Looks good. Could we change the icon to something that says "open"? Since some of those objects are not editable for example PipelineRun. User can't re-apply those objects |
|
@siamaksade can you check the icon in image looks good to you? |
Codecov Report
@@ Coverage Diff @@
## master #241 +/- ##
==========================================
+ Coverage 71.09% 71.15% +0.06%
==========================================
Files 37 37
Lines 2363 2368 +5
Branches 396 397 +1
==========================================
+ Hits 1680 1685 +5
Misses 683 683
Continue to review full report at Codecov.
|
evidolob
reviewed
Apr 10, 2020
evidolob
approved these changes
Apr 10, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Provided Icon on every
tknresource, clicking on Icon will open the yaml on the editor.Fix: #224