Add support for v1beta1 API #245
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Yevhen Vydolob <yvydolob@redhat.com>
Signed-off-by: Yevhen Vydolob <yvydolob@redhat.com>
…to v1beta1-api Signed-off-by: Yevhen Vydolob <yvydolob@redhat.com>
Codecov Report
@@ Coverage Diff @@
## master #245 +/- ##
==========================================
- Coverage 71.15% 71.03% -0.12%
==========================================
Files 37 37
Lines 2368 2372 +4
Branches 397 400 +3
==========================================
Hits 1685 1685
- Misses 683 687 +4
Continue to review full report at Codecov.
|
sudhirverma
reviewed
Apr 15, 2020
| @@ -3,6 +3,6 @@ kind: PipelineResource | |||
| metadata: | |||
| name: ${1:git-source} | |||
| spec: | |||
| type: ${2|git,image,pullRequest,cluster,storage|} | |||
| type: ${2|git,image,pullRequest,cluster,storage,gcs,build-gcs,cloudevent|} | |||
There was a problem hiding this comment.
apiVersion should be tekton.dev/v1beta1
There was a problem hiding this comment.
sudhirverma
approved these changes
Apr 15, 2020
This was referenced Apr 15, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR upgrades snippet content, fix some indentation issues.
Snippets migrated to
v1beta1version according to https://github.com/tektoncd/pipeline/blob/master/docs/migrating-v1alpha1-to-v1beta1.mdThis PR brings a new npm command to regenerate snippets json file.
Fix: #183
Also this PR fix: #184, #185, #225, #176