webview to start pipeline #323
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -6,3 +6,4 @@ out | |
| coverage | ||
|
|
||
| preview | ||
| *.jsx | ||
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -6,15 +6,28 @@ | |
| import { TektonItem } from './tektonitem'; | ||
| import { TektonNode, Command } from '../tkn'; | ||
| import { Progress } from '../util/progress'; | ||
| import { window, workspace } from 'vscode'; | ||
| import * as cliInstance from '../cli'; | ||
| import { cli } from '../cli'; | ||
| import { TknPipelineTrigger } from '../tekton'; | ||
| import { Trigger, PipelineContent } from './pipelinecontent'; | ||
| import pipelineViewLoader from '../view/pipeline/pipelineViewLoader'; | ||
| import { pipelineData } from './webviewstartpipeline'; | ||
|
|
||
| export class Pipeline extends TektonItem { | ||
|
|
||
|
|
||
| static checkWebViewStartPipeline(): boolean { | ||
| return workspace | ||
| .getConfiguration('vs-tekton') | ||
| .get<boolean>('StartPipeline'); | ||
| } | ||
|
|
||
| static async start(pipeline: TektonNode): Promise<string> { | ||
| if (Pipeline.checkWebViewStartPipeline()) { | ||
|
There was a problem hiding this comment. Maybe having separate command for webview wizard will be better? @siamaksade ? There was a problem hiding this comment. I think enabling webview from setting would be better. |
||
| pipelineViewLoader.loadView('Start Pipeline', await pipelineData(pipeline.getName())); | ||
| return null; | ||
| } | ||
| if (!pipeline) { | ||
| pipeline = await window.showQuickPick(await Pipeline.getPipelineNames(), {placeHolder: 'Select Pipeline to start', ignoreFocusOut: true}); | ||
| } | ||
|
|
@@ -33,7 +46,7 @@ export class Pipeline extends TektonItem { | |
| const pipelineTrigger = data.map<Trigger>(value => ({ | ||
| name: value.metadata.name, | ||
| resources: value.spec.resources, | ||
| parameters: value.spec.params ? value.spec.params : undefined, | ||
|
There was a problem hiding this comment. there you can use |
||
| workspaces: value.spec['workspaces'] ? value.spec['workspaces'] : undefined, | ||
| serviceAcct: value.spec.serviceAccount ? value.spec.serviceAccount : undefined | ||
| })).filter(function (obj) { | ||
|
|
||
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,101 @@ | ||
| /*----------------------------------------------------------------------------------------------- | ||
| * Copyright (c) Red Hat, Inc. All rights reserved. | ||
| * Licensed under the MIT License. See LICENSE file in the project root for license information. | ||
| *-----------------------------------------------------------------------------------------------*/ | ||
|
|
||
| import { Command } from '../tkn'; | ||
| import { TektonItem } from './tektonitem'; | ||
|
|
||
| export interface Param { | ||
| name: string; | ||
| type?: string; | ||
| } | ||
|
|
||
| export interface PipelineParam extends Param { | ||
| default?: string | string[]; | ||
| description?: string; | ||
| } | ||
|
|
||
| export interface PipelineResource { | ||
| name: string; | ||
| type: string; | ||
| } | ||
|
|
||
| export interface PipelineWorkspace extends Param { | ||
| type?: string; | ||
| workspace?: string; | ||
| data?: { | ||
| [key: string]: string; | ||
| }; | ||
| } | ||
|
|
||
|
|
||
| export interface PipelineTaskRef { | ||
| kind?: string; | ||
| name: string; | ||
| } | ||
|
|
||
| export interface PipelineTaskParam { | ||
| name: string; | ||
| value: any; | ||
| } | ||
|
|
||
| export interface PipelineTaskResource { | ||
| name: string; | ||
| resource?: string; | ||
| from?: string[]; | ||
| } | ||
|
|
||
| export interface PipelineTaskResources { | ||
| inputs?: PipelineTaskResource[]; | ||
| outputs?: PipelineTaskResource[]; | ||
| } | ||
|
|
||
| export interface PipelineTask { | ||
| name: string; | ||
| runAfter?: string[]; | ||
| taskRef: PipelineTaskRef; | ||
| params?: PipelineTaskParam[]; | ||
| resources?: PipelineTaskResources; | ||
| workspaces?: PipelineWorkspace[]; | ||
| } | ||
|
|
||
| interface TknResource { | ||
| pipeline: { | ||
| spec: { | ||
| params?: PipelineParam[]; | ||
| resources?: PipelineResource[]; | ||
| workspaces?: PipelineWorkspace[]; | ||
| tasks: PipelineTask[]; | ||
| serviceAccountName?: string; | ||
| }; | ||
| }; | ||
| pipelineResource: any; | ||
| Secret: any; | ||
| ConfigMap: any; | ||
| PersistentVolumeClaim: any; | ||
| } | ||
|
|
||
|
|
||
| export const pipelineData = async (name: string) => { | ||
|
There was a problem hiding this comment. I think you can define function instead of exporting constant, which you assign lambda, or you have particular reason to do that? There was a problem hiding this comment. No particular reason for using lambda. I will use function here. |
||
| const pipelineData: TknResource = { | ||
| pipeline: undefined, | ||
| pipelineResource: undefined, | ||
| Secret: undefined, | ||
| ConfigMap: undefined, | ||
| PersistentVolumeClaim: undefined | ||
| }; | ||
| const pipeline = await TektonItem.tkn.execute(Command.getPipeline(name), process.cwd(), false); | ||
| pipelineData.pipeline = JSON.parse(pipeline.stdout); | ||
| if (pipelineData.pipeline.spec.workspaces) { | ||
| const secret = await TektonItem.tkn.execute(Command.workspace('Secret'), process.cwd(), false); | ||
| pipelineData.Secret = JSON.parse(secret.stdout).items; | ||
| const configMap = await TektonItem.tkn.execute(Command.workspace('ConfigMap'), process.cwd(), false); | ||
| pipelineData.ConfigMap = JSON.parse(configMap.stdout).items; | ||
| const pvc = await TektonItem.tkn.execute(Command.workspace('PersistentVolumeClaim'), process.cwd(), false); | ||
| pipelineData.PersistentVolumeClaim = JSON.parse(pvc.stdout).items; | ||
| } | ||
| const resource = await TektonItem.tkn.execute(Command.getPipelineResource(), process.cwd(), false); | ||
| pipelineData.pipelineResource = JSON.parse(resource.stdout).items; | ||
| return pipelineData; | ||
| } | ||
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Enable/disable to Start Pipeline in webViewIs not clear as for me,maybe
Enable WebView Wizard to Start Pipelineis better.As for me
Enable/disableis very confusing.