Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Provide full import path for index.ts file #378

Closed
wants to merge 1 commit into from

Conversation

sudhirverma
Copy link
Contributor

No description provided.

@codecov-commenter
Copy link

Codecov Report

Merging #378 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #378   +/-   ##
=======================================
  Coverage   72.92%   72.92%           
=======================================
  Files          52       52           
  Lines        3550     3550           
  Branches      642      642           
=======================================
  Hits         2589     2589           
  Misses        961      961           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 04f0059...fb71281. Read the comment docs.

@gorkem
Copy link
Collaborator

gorkem commented Aug 2, 2020

out of curiosity Why was this change .needed ?

@sudhirverma
Copy link
Contributor Author

out of curiosity Why was this change .needed ?

we are following the import statement with the filename as we have done for other import. and in index.ts there are few functions which we are using for better understanding I am using the import statement with the file name.

@sudhirverma
Copy link
Contributor Author

closing this PR as fix in #387

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants