Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

wizard to restart pipelinerun. #390

Merged
merged 10 commits into from
Sep 9, 2020
Merged

Conversation

sudhirverma
Copy link
Contributor

Fix: #351

@sudhirverma sudhirverma marked this pull request as draft August 18, 2020 08:44
@codecov-commenter
Copy link

codecov-commenter commented Aug 18, 2020

Codecov Report

Merging #390 into master will decrease coverage by 0.87%.
The diff coverage is 35.22%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #390      +/-   ##
==========================================
- Coverage   73.44%   72.57%   -0.88%     
==========================================
  Files          53       54       +1     
  Lines        3592     3664      +72     
  Branches      644      660      +16     
==========================================
+ Hits         2638     2659      +21     
- Misses        954     1005      +51     
Impacted Files Coverage Δ
src/kubernetes.ts 67.64% <0.00%> (ø)
src/pipeline/wizard.ts 20.00% <0.00%> (-0.29%) ⬇️
src/tekton/pipeline.ts 53.62% <0.00%> (-8.70%) ⬇️
src/tekton/pipelinecontent.ts 93.63% <ø> (ø)
src/tekton/tektonitem.ts 63.95% <9.09%> (-8.42%) ⬇️
src/tekton/restartpipelinerundata.ts 37.28% <37.28%> (ø)
src/tekton/webviewstartpipeline.ts 50.00% <50.00%> (+21.42%) ⬆️
src/tekton/pipelinerun.ts 83.72% <60.00%> (-7.46%) ⬇️
src/extension.ts 89.06% <100.00%> (+0.08%) ⬆️
... and 1 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 085b7ef...33d811e. Read the comment docs.

@sudhirverma sudhirverma marked this pull request as ready for review August 20, 2020 13:48
@sudhirverma sudhirverma changed the title [WIP] wizard to restart pipelinerun. wizard to restart pipelinerun. Aug 20, 2020
Copy link
Collaborator

@evidolob evidolob left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
I'm not sure why you delete 'Start Las Run' command?

@sudhirverma
Copy link
Contributor Author

LGTM
I'm not sure why you delete 'Start Las Run' command?

I have removed the Start Last Run command because we restart command for each pipelineRun.

@evidolob
Copy link
Collaborator

evidolob commented Sep 9, 2020

As for me they do similar stuff but they have differed purpose. Is @siamaksade asked to delete it?

@sudhirverma
Copy link
Contributor Author

As for me they do similar stuff but they have differed purpose. Is @siamaksade asked to delete it?

nope. @siamaksade Do you want me to keep Start Last Run and Resart both command or only Restart should work?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Allow opening start pipeline wizard with params from previous pipelineruns
3 participants