Provide a way to get expose url from tree view #447
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
evidolob
reviewed
Nov 12, 2020
src/tekton/triggertemplate.ts
Outdated
| for (const triggers of eventListener.spec.triggers) { | ||
| if (triggers?.template?.name === trigger.getName()) { | ||
| await TriggerTemplate.getExposeURl(eventListener.status.configuration.generatedName); | ||
| vscode.window.showInformationMessage('Expose URl successfully copy'); |
There was a problem hiding this comment.
Maybe Expose URl successfully copied ? @siamaksade ?
Codecov Report
@@ Coverage Diff @@
## master #447 +/- ##
==========================================
+ Coverage 74.89% 75.16% +0.26%
==========================================
Files 64 64
Lines 4107 4147 +40
Branches 738 745 +7
==========================================
+ Hits 3076 3117 +41
+ Misses 1031 1030 -1
Continue to review full report at Codecov.
|
sudhirverma
changed the title
sudhirverma
changed the title
evidolob
approved these changes
Nov 12, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix: #404