Add telemetry support #498
Conversation
sudhirverma
force-pushed
the
470
branch
2 times, most recently
from
76417fc
to
eb14dcd
Compare
Codecov Report
@@ Coverage Diff @@
## master #498 +/- ##
==========================================
+ Coverage 67.20% 67.39% +0.19%
==========================================
Files 79 80 +1
Lines 5327 5365 +38
Branches 934 941 +7
==========================================
+ Hits 3580 3616 +36
- Misses 1747 1749 +2
Continue to review full report at Codecov.
|
|
@sudhirverma I got this error when try to launch extension in dev mode: |
I have launch extension in my mac and ubuntu system it is working fine for me. |
|
@sudhirverma Try to delete |
I think we can't delete the |
|
Why? I try to launch extension with telemetry first time, so I do not have that in my preferences |
I had remove and install it again. I didn’t get the error. |
|
That strange, I rebuild everything again and it start working |
src/extension.ts
Outdated
| telemetryProps.error = result.error.toString(); | ||
| sendTelemetry('command', telemetryProps); | ||
| } else { | ||
| if (commandId === 'kubectl.version') { |
There was a problem hiding this comment.
I think that we need same for tkn versions, I mean that we need to store each of tkn cli, tekton version and triggers versions as separate values, that will help us to analyze used versions more easy.
There was a problem hiding this comment.
when we store tkn version it looks like Client version: 0.15.0 Pipeline version: v0.16.3 Triggers version: v0.8.1 which is similar to what I am doing with kubectl.
There was a problem hiding this comment.
Yes, that what I was thinking, if we store all tekton related versions in one row. The in case if we want to measure how much of our users use some specific Pipeline version it may be a bit difficult.
There was a problem hiding this comment.
You mean we should send the tkn related version separately? for Client, Pipeline, and trigger.
There was a problem hiding this comment.
I'm not 100% sure, I think you can ask Fred how to do it better.
There was a problem hiding this comment.
@fbricon What's your opinion on sending data for tkn version it contains Client, Pipeline, and trigger version for example see in image. Should we send them separately?
Fix: #470