Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix bug on finding reference resource while deleting #542

Merged
merged 6 commits into from
Apr 2, 2021

Conversation

sudhirverma
Copy link
Contributor

No description provided.

Copy link
Contributor

@lstocchi lstocchi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

By looking at the code it looks good now. Added some ideas to improve it.

src/commands/delete.ts Outdated Show resolved Hide resolved
src/util/check-ref-resource.ts Outdated Show resolved Hide resolved
src/util/check-ref-resource.ts Outdated Show resolved Hide resolved
@codecov-io
Copy link

Codecov Report

Merging #542 (6d6e94a) into master (9972c85) will decrease coverage by 0.03%.
The diff coverage is 85.71%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #542      +/-   ##
==========================================
- Coverage   68.28%   68.25%   -0.04%     
==========================================
  Files          96       96              
  Lines        5774     5781       +7     
  Branches     1002     1003       +1     
==========================================
+ Hits         3943     3946       +3     
- Misses       1831     1835       +4     
Impacted Files Coverage Δ
src/commands/delete.ts 39.80% <62.50%> (ø)
src/cli-command.ts 67.14% <100.00%> (+0.32%) ⬆️
src/util/check-ref-resource.ts 95.00% <100.00%> (ø)
src/hub/task-page-view.ts 19.64% <0.00%> (+0.01%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9972c85...6d6e94a. Read the comment docs.

src/commands/delete.ts Outdated Show resolved Hide resolved
src/commands/delete.ts Outdated Show resolved Hide resolved
src/commands/delete.ts Outdated Show resolved Hide resolved
Copy link
Contributor

@lstocchi lstocchi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested and works fine. Some more comments/ideas below that came to my mind by looking at the code. But it works the same as it is.

src/cli-command.ts Outdated Show resolved Hide resolved
src/commands/delete.ts Outdated Show resolved Hide resolved
src/util/check-ref-resource.ts Outdated Show resolved Hide resolved
src/commands/delete.ts Outdated Show resolved Hide resolved
@sudhirverma sudhirverma merged commit 28c1364 into redhat-developer:master Apr 2, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants