Add 'Extract Task spec' CodeAction #546
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Yevhen Vydolob <yvydolob@redhat.com>
Codecov Report
@@ Coverage Diff @@
## master #546 +/- ##
==========================================
+ Coverage 68.22% 68.64% +0.41%
==========================================
Files 97 97
Lines 5785 5874 +89
Branches 1019 1032 +13
==========================================
+ Hits 3947 4032 +85
- Misses 1838 1842 +4
Continue to review full report at Codecov.
|
sudhirverma
reviewed
Apr 8, 2021
Signed-off-by: Yevhen Vydolob <yvydolob@redhat.com>
sudhirverma
reviewed
Apr 8, 2021
| const virtDoc = this.getDocForExtractedTask(name, type, action.taskSpecText); | ||
|
|
||
| const saveError = await tektonVfsProvider.saveTektonDocument(virtDoc); | ||
| if (saveError) { |
There was a problem hiding this comment.
I got error here error converting YAML to JSON: yaml: line 4: did not find expected key
virtDoc =
apiVersion: tekton.dev/v1beta1
kind: Task
metadata:
name: new-task
{}
spec:
resources:
inputs:
- name: pipeline-git
type: git
outputs:
- name: pipeline-git
type: git
steps:
- args:
- '-c'
- |
ls -al $(resources.inputs.pipeline-git.path)
command:
- bash
image: ubuntu
name: list
resources: {}
There was a problem hiding this comment.
Now it should work
Signed-off-by: Yevhen Vydolob <yvydolob@redhat.com>
siamaksade
approved these changes
Apr 8, 2021
sudhirverma
approved these changes
Apr 8, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix: #511
Demo:
Screen.Recording.2021-04-06.at.16.17.16.mov