Fix add trigger and added test #561
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #561 +/- ##
==========================================
+ Coverage 67.28% 67.70% +0.41%
==========================================
Files 96 97 +1
Lines 6053 6096 +43
Branches 1052 1061 +9
==========================================
+ Hits 4073 4127 +54
+ Misses 1980 1969 -11
Continue to review full report at Codecov.
|
evidolob
reviewed
Apr 29, 2021
src/util/tknversion.ts
Outdated
| @@ -45,3 +45,20 @@ export function getVersion(tektonVersion: string): TknVersion { | |||
| return tknVersion; | |||
| } | |||
| } | |||
|
|
|||
| export function compareVersion(a: string, b: string): boolean { | |||
There was a problem hiding this comment.
you could use semver package to compare versions
evidolob
approved these changes
May 11, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.