Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hide user local path #578

Merged
merged 2 commits into from
May 17, 2021
Merged

Hide user local path #578

merged 2 commits into from
May 17, 2021

Conversation

sudhirverma
Copy link
Contributor

No description provided.

@codecov-commenter
Copy link

codecov-commenter commented May 13, 2021

Codecov Report

Merging #578 (952c71a) into master (31fdd36) will increase coverage by 0.04%.
The diff coverage is 100.00%.

❗ Current head 952c71a differs from pull request most recent head 8cc9198. Consider uploading reports for the commit 8cc9198 to get more accurate results
Impacted file tree graph

@@            Coverage Diff             @@
##           master     #578      +/-   ##
==========================================
+ Coverage   67.64%   67.69%   +0.04%     
==========================================
  Files          99       99              
  Lines        6141     6150       +9     
  Branches     1054     1056       +2     
==========================================
+ Hits         4154     4163       +9     
  Misses       1987     1987              
Impacted Files Coverage Δ
src/util/hideclusterinformation.ts 89.47% <100.00%> (+9.47%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 31fdd36...8cc9198. Read the comment docs.

Copy link
Collaborator

@evidolob evidolob left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@sudhirverma Could you add test for this?

@sudhirverma sudhirverma merged commit 0e8da8c into redhat-developer:master May 17, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants