Fix streaming logs output from a PipelineRun on start #606
Conversation
Codecov Report
@@ Coverage Diff @@
## master #606 +/- ##
==========================================
- Coverage 68.22% 68.21% -0.02%
==========================================
Files 103 103
Lines 6316 6326 +10
Branches 1146 1149 +3
==========================================
+ Hits 4309 4315 +6
- Misses 2007 2011 +4
Continue to review full report at Codecov.
|
package.json
Outdated
| @@ -97,6 +97,12 @@ | |||
| "default": false, | |||
| "description": "Show Tekton Pipeline output channel when new text added to output stream" | |||
| }, | |||
| "vs-tekton.showPipelineRunFollowLogs": { | |||
| "title": "Show pipelineRun follow Logs", | |||
There was a problem hiding this comment.
I think it would be better to have preference for regular start pipeline command, something like Show logs on pipeline start/run, instead of having separate command. Or at least title of this command can be changed to: Start Pipeline with logs.
@mohitsuman WDYT?
There was a problem hiding this comment.
I think having vscode setting preference on the pipeline run and logs makes sense. And for the title Start Pipeline with logs works.
package.json
Outdated
| "title": "Start pipeline with logs", | ||
| "type": "boolean", | ||
| "default": true, | ||
| "description": "Show pipelineRun follow logs while starting pipeline." |
There was a problem hiding this comment.
pipelineRun -> PipelineRun
Fix: #350