Tekton: Delete commands should show confirmation info message and run without terminal
#98
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sudhirverma
changed the title
Tekton: Delete commands should show confirmation info message and run without terminalTekton: Delete commands should show confirmation info message and run without terminal [WIP]
Codecov Report
@@ Coverage Diff @@
## master #98 +/- ##
=========================================
+ Coverage 72.57% 73.77% +1.2%
=========================================
Files 19 19
Lines 999 1045 +46
Branches 148 148
=========================================
+ Hits 725 771 +46
Misses 274 274
Continue to review full report at Codecov.
|
sudhirverma
force-pushed
the
92
branch
6 times, most recently
from
ea3a1a9
to
f40960e
Compare
sudhirverma
changed the title
Tekton: Delete commands should show confirmation info message and run without terminal [WIP]Tekton: Delete commands should show confirmation info message and run without terminal
dgolovin
requested changes
Dec 10, 2019
| @@ -16,8 +18,15 @@ export class ClusterTask extends TektonItem { | |||
| if (clustertasks) { ClusterTask.tkn.executeInTerminal(Command.listClusterTasksinTerminal()); } | |||
| } | |||
|
|
|||
| static async delete(clustertask: TektonNode): Promise<void> { | |||
| if (clustertask) { ClusterTask.tkn.executeInTerminal(Command.deleteClusterTask(clustertask.getName())); } | |||
| static async delete(clustertask: TektonNode): Promise<string> { | |||
There was a problem hiding this comment.
Seems to be good request except some issues with messages:
- Every message should start with capital letter.
- Should use appropriate articles a/an/the.
- Message should finish with './?/!'
- Custom resource names should be in camel case: ClusterTask, TaskRun, PiplelineResource, PipelineRun, Task, Pipeline
Below is an example:
const value = await window.showWarningMessage(`Do you want to delete the ClusterTask '${clustertask.getName()}\'?`, 'Yes', 'Cancel');
if (value === 'Yes') {
return Progress.execFunctionWithProgress(`Deleting the ClusterTask '${clustertask.getName()}'.`, () =>
ClusterTask.tkn.execute(Command.deleteClusterTask(clustertask.getName())))
.then(() => `The ClusterTask '${clustertask.getName()}' successfully deleted.`)
.catch((err) => Promise.reject(`Failure to delete the ClusterTask '${clustertask.getName()}': '${err}'.`));
|
Please rebase on top of origin/master. |
dgolovin
approved these changes
Dec 12, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix: #92