-
Notifications
You must be signed in to change notification settings - Fork 261
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Publish to npm on each commit in master #333
Conversation
Signed-off-by: Yevhen Vydolob <yvydolob@redhat.com>
Co-authored-by: Josh Pinkney <Joshpinkney@gmail.com>
If you merge this you will have 2 workflow files that will both fire when merge to master is detected. They do not have a dependency so failing the test will not keep it from releasing. |
@joshuawilson nice catch. |
You could have one for |
Yeah good catch, I completely forgot about that |
Chaining would be cleaner as it would not duplicate the test and build steps but I can not find a way to do it. |
OK, I think I know how to do that, I will update PR soon, all steps will be in one workflow |
Signed-off-by: Yevhen Vydolob <yvydolob@redhat.com>
…aml-language-server into publish-next-versions
.github/workflows/CI.yaml
Outdated
@@ -50,3 +51,9 @@ jobs: | |||
uses: coverallsapp/github-action@master | |||
with: | |||
github-token: ${{ secrets.GITHUB_TOKEN }} | |||
|
|||
- name: Publish | |||
if: ${{ success() && github.event_name == 'push' && github.ref == 'refs/heads/master'}} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
How do you ensure that the other workflow runs first?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Which one? We have only one workflow.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry, I thought this was an update to the CD workflow. I missed that are only using one now.
This is a nice solution, good work.
Signed-off-by: Yevhen Vydolob <yvydolob@redhat.com>
This PR add GH Action workflow which publish changes in master branch to npm registry with
next
version tag.