Allow users to change the default k8s schema #824
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add a new notification to allow users to change the default Kubernetes schema on the fly.
someone-stole-my-name
requested a review
from msivasubramaniaan
as a code owner
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Currently, there is no way to set the Kubernetes schema, it is hard-coded and a lot of internal magic depends on it. If you try to do it through the existing methods, i.e. a comment or an association, it offers a subpar experience with bad diagnostics and incomplete completion suggestions.
This PR exposes new notification to allow third party extensions and users to change the default Kubernetes schema on the fly and still get diagnostics and autocompletion from the LS.
What issues does this PR fix or reference?
#778