Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Send real errors to telemetry #981

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Send real errors to telemetry #981

wants to merge 1 commit into from

Commits on Jul 7, 2024

  1. Send real errors to telemetry 

    Every call to `telemetry.sendError` contained the same boilerplate code
to create an object with the property `error`, which contains a string
representation of the real error. This change moves this conversion into
the `Telemetry` implementation. This reduces the need for boilerplate
code in other places.

This change also affects `monaco-yaml`. Because the telemetry now
resolves the real error, the browser can log the error to the console
with a better stack trace.
    @remcohaszing
    remcohaszing committed Jul 7, 2024
    Configuration menu
    Copy the full SHA
    10dc8e6 View commit details
    Browse the repository at this point in the history