Valid conditions: false positive

[michaelryanpeter]

Describe the bug
Currently, the valid conditions rule prints an error for the valid use case of using an inline conditional. Here is a link to the error: openshift/openshift-docs#82304 (comment)

Examples:

• This word or expression triggers an illegitimate vale alert:

ifndef::olmv1-pullsecret-proc[For more information, see "Creating a pull secret for catalogs hosted on a secure registry".]

I am not sure if the regex can be extended to check for this use case. This might just be a false positive that we need to accept, since having a rule that catches open conditions seems more important than not flagging an error on this edge case.

[aireilly]

hmm. this sounds tricky! I'm not sure how we'd handle this tbh

[michaelryanpeter]

It might not be worth doing, tbh. I just thought I would point it out.

[aireilly]

It's a dilly of a pickle. The one-line ifdef has the same syntax as a regular ifdef with closing statement. That's an unfortunate design when you are using regex matching instead of proper syntax validation.

Actually this is easily addressed with better regex

[aireilly]

@michaelryanpeter vale sync to pick up the changes. LMK if you see anything else or this doesn't work for you