Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

OSDOCS#12021: Known issue with OLM v1 private registries #82304

Merged
merged 1 commit into from
Sep 25, 2024
Merged

OSDOCS#12021: Known issue with OLM v1 private registries #82304

merged 1 commit into from
Sep 25, 2024

Conversation

michaelryanpeter
Copy link
Contributor

@michaelryanpeter michaelryanpeter commented Sep 23, 2024 •
edited
Loading

Version(s): 4.17

Issue: OSDOCS-12021

Link to docs preview:

QE review:

  • QE has approved this change.

Additional information:

@michaelryanpeter michaelryanpeter added this to the Planned for 4.17 GA milestone Sep 23, 2024
@openshift-ci-robot
Copy link

openshift-ci-robot commented Sep 23, 2024 •
edited by openshift-ci bot
Loading

@michaelryanpeter: This pull request references OSDOCS-12021 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.18.0" version, but no target version was set.

In response to this:

Version(s): 4.17

Issue:

Link to docs preview:

QE review:

  • QE has approved this change.

Additional information:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Sep 23, 2024
@openshift-ci-robot
Copy link

openshift-ci-robot commented Sep 23, 2024 •
edited by openshift-ci bot
Loading

@michaelryanpeter: This pull request references OSDOCS-12021 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.18.0" version, but no target version was set.

In response to this:

Version(s): 4.17

Issue:

Link to docs preview:

QE review:

  • QE has approved this change.

Additional information:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci openshift-ci bot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Sep 23, 2024
@ocpdocs-previewbot
Copy link

ocpdocs-previewbot commented Sep 23, 2024 •
edited
Loading

🤖 Wed Sep 25 18:16:59 - Prow CI generated the docs preview:

https://82304--ocpdocs-pr.netlify.app/
https://82304--ocpdocs-pr.netlify.app/openshift-enterprise/latest/extensions/arch/catalogd.html
https://82304--ocpdocs-pr.netlify.app/openshift-enterprise/latest/extensions/catalogs/creating-catalogs.html
https://82304--ocpdocs-pr.netlify.app/openshift-enterprise/latest/extensions/catalogs/fbc.html
https://82304--ocpdocs-pr.netlify.app/openshift-enterprise/latest/extensions/catalogs/managing-catalogs.html
https://82304--ocpdocs-pr.netlify.app/openshift-enterprise/latest/extensions/catalogs/rh-catalogs.html
https://82304--ocpdocs-pr.netlify.app/openshift-enterprise/latest/extensions/ce/managing-ce.html
https://82304--ocpdocs-pr.netlify.app/openshift-enterprise/latest/extensions/ce/upgrade-edges.html
https://82304--ocpdocs-pr.netlify.app/openshift-enterprise/latest/extensions/index.html

@michaelryanpeter michaelryanpeter changed the title OSDOCS-12021: Known issue with OLM v1 private registries OSDOCS#12021: Known issue with OLM v1 private registries Sep 23, 2024
@openshift-ci-robot openshift-ci-robot removed the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Sep 23, 2024
@michaelryanpeter michaelryanpeter force-pushed the OSDOCS-12021-olmv1-private-registry-known-issue branch from 7193081 to 3b11738 Compare September 23, 2024 19:59
@openshift openshift deleted a comment from openshift-ci-robot Sep 23, 2024
@mwerner2113
Copy link

Should definitely be an admonition here instead of in Managing Catalogs.

Think it's very possible that folks go straight to a procedure either in the TOC or from google search and then miss the admonition. Can make more suggestions of where it should go later tonight or tomorrow morning.

@michaelryanpeter michaelryanpeter force-pushed the OSDOCS-12021-olmv1-private-registry-known-issue branch 5 times, most recently from 3f7d7a6 to 1425eff Compare September 24, 2024 14:48
@openshift-ci openshift-ci bot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Sep 24, 2024
@michaelryanpeter michaelryanpeter mentioned this pull request Sep 24, 2024
Closed
@michaelryanpeter
Copy link
Contributor Author

@kuiwang02, @bandrade, or @jianzhangbjz PTAL

@joelanford
Copy link
Member

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Sep 24, 2024
@kuiwang02
Copy link

/lgtm

@michaelryanpeter
Copy link
Contributor Author

/label peer-review-needed

@openshift-ci openshift-ci bot added the peer-review-needed Signifies that the peer review team needs to review this PR label Sep 25, 2024
@jeana-redhat jeana-redhat added the peer-review-in-progress Signifies that the peer review team is reviewing this PR label Sep 25, 2024
jeana-redhat
jeana-redhat reviewed Sep 25, 2024
View reviewed changes
Copy link
Contributor

@jeana-redhat jeana-redhat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Globally: s/Red Hat/Red{nbsp}Hat

Otherwise LGTM!

/remove-label peer-review-in-progress
/remove-label peer-review-needed
/label peer-review-done

modules/olmv1-red-hat-catalogs.adoc Show resolved Hide resolved
@openshift-ci openshift-ci bot added peer-review-done Signifies that the peer review team has reviewed this PR and removed peer-review-in-progress Signifies that the peer review team is reviewing this PR peer-review-needed Signifies that the peer review team needs to review this PR labels Sep 25, 2024
@michaelryanpeter michaelryanpeter force-pushed the OSDOCS-12021-olmv1-private-registry-known-issue branch from 1425eff to bfe725b Compare September 25, 2024 18:10
@openshift-ci openshift-ci bot removed the lgtm Indicates that a PR is ready to be merged. label Sep 25, 2024
@openshift-ci OpenShift CI
Copy link

openshift-ci bot commented Sep 25, 2024

New changes are detected. LGTM label has been removed.

@openshift-ci OpenShift CI
Copy link

openshift-ci bot commented Sep 25, 2024

@michaelryanpeter: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@michaelryanpeter
Copy link
Contributor Author

ack'ed by PX via Content Strategy

@michaelryanpeter michaelryanpeter merged commit ad5f0f9 into openshift:main Sep 25, 2024
2 checks passed
@michaelryanpeter
Copy link
Contributor Author

/cherrypick enterprise-4.17

@openshift-cherrypick-robot
Copy link

@michaelryanpeter: new pull request created: #82502

In response to this:

/cherrypick enterprise-4.17

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@openshift-cherrypick-robot openshift-cherrypick-robot mentioned this pull request Sep 25, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ocpdocs-vale-bot ocpdocs-vale-bot ocpdocs-vale-bot left review comments

@jeana-redhat jeana-redhat jeana-redhat left review comments

@kuiwang02 kuiwang02 kuiwang02 left review comments

@everettraven everettraven everettraven approved these changes

Assignees

@joelanford joelanford

@kuiwang02 kuiwang02

Labels
branch/enterprise-4.17 peer-review-done Signifies that the peer review team has reviewed this PR size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
OCP 4.17 GA
Development

Successfully merging this pull request may close these issues.
10 participants
@michaelryanpeter @openshift-ci-robot @ocpdocs-previewbot @mwerner2113 @joelanford @kuiwang02 @openshift-cherrypick-robot @everettraven @jeana-redhat @ocpdocs-vale-bot