Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

operators [CI] azure-service-operator (1.0.27207) #71

Conversation

babbageclunk
Copy link
Contributor

Signed-off-by: Christian Muirhead christian.muirhead@microsoft.com

Thanks submitting your Operator. Please check below list before you create your Pull Request.

Updates to existing Operators

  • Did you create a ci.yaml file according to the update instructions?
  • Is your new CSV pointing to the previous version with the replaces property if you chose replaces-mode via the updateGraph property in ci.yaml?
  • [ x Is your new CSV referenced in the appropriate channel defined in the package.yaml or annotations.yaml ?
  • Have you tested an update to your Operator when deployed via OLM?
  • Is your submission signed?

Your submission should not

  • Modify more than one operator
  • Modify an Operator you don't own
  • Rename an operator - please remove and add with a different name instead
  • Modify any files outside the above mentioned folders
  • Contain more than one commit. Please squash your commits.

Operator Description must contain (in order)

  1. Description about the managed Application and where to find more information
  2. Features and capabilities of your Operator and how to use it
  3. Any manual steps about potential pre-requisites for using your Operator

Operator Metadata should contain

  • Human readable name and 1-liner description about your Operator
  • Valid category name1
  • One of the pre-defined capability levels2
  • Links to the maintainer, source code and documentation
  • Example templates for all Custom Resource Definitions intended to be used
  • A quadratic logo

Remember that you can preview your CSV here.

--

1 If you feel your Operator does not fit any of the pre-defined categories, file an issue against this repo and explain your need

2 For more information see here

@openshift-ci openshift-ci bot requested review from J0zi and mvalarh August 2, 2021 03:31
@openshift-ci openshift-ci bot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Aug 2, 2021
@openshift-ci
Copy link

openshift-ci bot commented Aug 2, 2021

Hi @babbageclunk. Thanks for your PR.

I'm waiting for a redhat-openshift-ecosystem member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@github-actions github-actions bot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. dco-failed package-validated openshift-started-4.6 openshift-started-4.7 openshift-started-4.8 and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Aug 2, 2021
@J0zi
Copy link
Contributor

J0zi commented Aug 2, 2021

/test all

@framework-automation
Copy link
Collaborator

/merge possible

@github-actions
Copy link
Contributor

github-actions bot commented Aug 2, 2021

Current PR can be merged automatically, but there is missing authorized-changes label. One can find out more info here.

@github-actions
Copy link
Contributor

github-actions bot commented Aug 2, 2021

DCO is missing. Please signoff your commits !!!

@framework-automation
Copy link
Collaborator

/merge possible

@github-actions
Copy link
Contributor

github-actions bot commented Aug 2, 2021

Current PR can be merged automatically, but there is missing authorized-changes label. One can find out more info here.

Signed-off-by: Christian Muirhead <christian.muirhead@microsoft.com>
@framework-automation
Copy link
Collaborator

/merge possible

@github-actions
Copy link
Contributor

github-actions bot commented Aug 3, 2021

Current PR can be merged automatically, but there is missing authorized-changes label. One can find out more info here.

@babbageclunk
Copy link
Contributor Author

I've made the reviewers change but it looks like that will only help with auto-merging once this has landed. Can someone merge this for me? Possibly @madorn?

@J0zi J0zi merged commit 5a752f5 into redhat-openshift-ecosystem:main Aug 4, 2021
@babbageclunk babbageclunk deleted the azure-service-operator-1.0.27207 branch August 4, 2021 22:08
rooftopcellist pushed a commit to rooftopcellist/community-operators-prod that referenced this pull request Nov 1, 2022
Signed-off-by: Piyush Nimbalkar <pnimbalkar@purestorage.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants