Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

operators [CI] tidb-operator (1.3.1) #860

Merged
merged 7 commits into from
Mar 28, 2022

Conversation

KanShiori
Copy link
Contributor

Signed-off-by: Shiori sihao.yu@pingcap.com

Thanks submitting your Operator. Please check below list before you create your Pull Request.

New Submissions

Updates to existing Operators

  • Did you create a ci.yaml file according to the update instructions?
  • Is your new CSV pointing to the previous version with the replaces property if you chose replaces-mode via the updateGraph property in ci.yaml?
  • Is your new CSV referenced in the appropriate channel defined in the package.yaml or annotations.yaml ?
  • Have you tested an update to your Operator when deployed via OLM?
  • Is your submission signed?

Your submission should not

  • Modify more than one operator
  • Modify an Operator you don't own
  • Rename an operator - please remove and add with a different name instead
  • Modify any files outside the above mentioned folders
  • Contain more than one commit. Please squash your commits.

Operator Description must contain (in order)

  1. Description about the managed Application and where to find more information
  2. Features and capabilities of your Operator and how to use it
  3. Any manual steps about potential pre-requisites for using your Operator

Operator Metadata should contain

  • Human readable name and 1-liner description about your Operator
  • Valid category name1
  • One of the pre-defined capability levels2
  • Links to the maintainer, source code and documentation
  • Example templates for all Custom Resource Definitions intended to be used
  • A quadratic logo

Remember that you can preview your CSV here.

--

1 If you feel your Operator does not fit any of the pre-defined categories, file an issue against this repo and explain your need

2 For more information see here

Signed-off-by: Shiori <sihao.yu@pingcap.com>
@openshift-ci openshift-ci bot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Feb 24, 2022
@openshift-ci
Copy link

openshift-ci bot commented Feb 24, 2022

Hi @KanShiori. Thanks for your PR.

I'm waiting for a redhat-openshift-ecosystem member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci openshift-ci bot requested review from J0zi and mvalarh February 24, 2022 03:44
@github-actions github-actions bot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Feb 24, 2022
Signed-off-by: Shiori <sihao.yu@pingcap.com>
@github-actions
Copy link
Contributor

Automatic Cluster Version Label (OCP) - packagemanifest only

Starting OCP v4.9 (based on k8s 1.22) some old API were deprecated(Deprecated API Migration Guide from v1.22, OKD/OpenShift Catalogs criteria and options). User can set com.redhat.openshift.versions: <versions>in its bundle annotations.yaml file to limit specific operator version to be visible on certain cluster.
Users can set label only when the operator is in bundle format. For packagemanifest format it is not possible to set this lablel, but community-operators pipeline can automatically set such label to the bundle. User have to allow it by putting packagemanifestClusterVersionLabel: auto in ci.yaml file

$ cat <path-to-operator>/ci.yaml
packagemanifestClusterVersionLabel: auto

More info here.

Signed-off-by: Shiori <sihao.yu@pingcap.com>
Signed-off-by: Shiori <sihao.yu@pingcap.com>
@github-actions github-actions bot changed the title operators tidb-operator (1.3.1) operators [CI] tidb-operator (1.3.1) Feb 24, 2022
@framework-automation
Copy link
Collaborator

/merge possible

@openshift-ci
Copy link

openshift-ci bot commented Mar 7, 2022

@KanShiori: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/4.7-deploy-operator-on-openshift 7181466 link true /test 4.7-deploy-operator-on-openshift
ci/prow/4.6-deploy-operator-on-openshift 7181466 link true /test 4.6-deploy-operator-on-openshift
ci/prow/4.8-deploy-operator-on-openshift 7181466 link true /test 4.8-deploy-operator-on-openshift

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@KanShiori
Copy link
Contributor Author

KanShiori commented Mar 9, 2022

@J0zi I found the operator is incompatible for Openshift v4.8 or before, can I skip these version?

@J0zi
Copy link
Contributor

J0zi commented Mar 28, 2022

@KanShiori you have old package format. New bundle format allows it by defining com.redhat.openshift.versions: "v4.9" in annotations.yaml. Our release will handle it for package format due to packagemanifestClusterVersionLabel: auto in ci.yaml. Our test pipeline should not fail. We will fix it.

@J0zi J0zi merged commit aec5e31 into redhat-openshift-ecosystem:main Mar 28, 2022
@J0zi
Copy link
Contributor

J0zi commented Mar 31, 2022

@KanShiori, my bad. By merging, it was released to all indexes. If OCP incompatibility is due deprecated k8s api, we handle it automatically. But in your case, k8s api is correct.
So you should convert operator to bundle format and set com.redhat.openshift.versions: v4.9 in metadata/annotations.yaml.

Conversion to bundle itself is an easy step, just changing dir structure and replacing central package file annotations files in every version. More info here.

@KanShiori
Copy link
Contributor Author

@KanShiori, my bad. By merging, it was released to all indexes. If OCP incompatibility is due deprecated k8s api, we handle it automatically. But in your case, k8s api is correct. So you should convert operator to bundle format and set com.redhat.openshift.versions: v4.9 in metadata/annotations.yaml.

Conversion to bundle itself is an easy step, just changing dir structure and replacing central package file annotations files in every version. More info here.

OK, I will do it.

DanArlowski pushed a commit to Sosivio/community-operators-prod that referenced this pull request Jul 6, 2022
* tidb operator v1.3.1

Signed-off-by: Shiori <sihao.yu@pingcap.com>

* tidb operator v1.3.1

Signed-off-by: Shiori <sihao.yu@pingcap.com>

* fix

Signed-off-by: Shiori <sihao.yu@pingcap.com>

* fix

Signed-off-by: Shiori <sihao.yu@pingcap.com>

* fix

Signed-off-by: Shiori <sihao.yu@pingcap.com>

* fix

Signed-off-by: Shiori <yshshihaoren@qq.com>

* fix

Signed-off-by: Shiori <yshshihaoren@qq.com>
oscerd pushed a commit to oscerd/community-operators-prod that referenced this pull request Oct 14, 2022
* tidb operator v1.3.1

Signed-off-by: Shiori <sihao.yu@pingcap.com>

* tidb operator v1.3.1

Signed-off-by: Shiori <sihao.yu@pingcap.com>

* fix

Signed-off-by: Shiori <sihao.yu@pingcap.com>

* fix

Signed-off-by: Shiori <sihao.yu@pingcap.com>

* fix

Signed-off-by: Shiori <sihao.yu@pingcap.com>

* fix

Signed-off-by: Shiori <yshshihaoren@qq.com>

* fix

Signed-off-by: Shiori <yshshihaoren@qq.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants