Handle empty object references when parsing imageStreams

Signed-off-by: Jose R. Gonzalez <komish@flutes.dev>
redhat-openshift-ecosystem · Oct 15, 2024 · c59f1a3 · c59f1a3
1 parent 5d2fbdb
commit c59f1a3
Show file tree

Hide file tree

Showing 2 changed files with 10 additions and 1 deletion.
diff --git a/internal/openshift/openshift.go b/internal/openshift/openshift.go
@@ -405,7 +405,7 @@ func (oe *openshiftClient) GetImages(ctx context.Context) (map[string]struct{},
 	}
 	for _, imageStream := range imageStreamList.Items {
 		for _, tag := range imageStream.Spec.Tags {
-			if tag.From.Kind == "DockerImage" {
+			if tag.From != nil && tag.From.Kind == "DockerImage" {
 				imageList[tag.From.Name] = struct{}{}
 			}
 		}

diff --git a/internal/openshift/openshift_test.go b/internal/openshift/openshift_test.go
@@ -81,6 +81,15 @@ var _ = Describe("OpenShift Engine", func() {
 						},
 					},
 				},
+				{
+					ObjectMeta: metav1.ObjectMeta{
+						Name:      "imagestream-empty-objectref",
+						Namespace: "testns",
+					},
+					Spec: imagestreamv1.ImageStreamSpec{
+						Tags: []imagestreamv1.TagReference{},
+					},
+				},
 			},
 		}