add exec.LookPath to check operator-sdk is in $PATH

[acornett21]

Motivation

The ux when a user does not have operator-sdk in their path leads to a confusing error that is hard to track down.

Current Error Message:

time="2024-10-02T15:57:04+02:00" level=info msg="check completed" check=ScorecardBasicSpecCheck err="failed to run operator-sdk scorecard: unexpected end of JSON input" result=ERROR

This error is not clear at all what is going on, but we do not have direct control of this once we shell out to operator-sdk

Changes

Add an explicit check to make sure that operator-sdk binary is in the users PATH. This provides an error message that is more clearer.

New Error Message:

time="2024-10-16T13:05:53-07:00" level=info msg="check completed" check=ScorecardBasicSpecCheck err="exec: \"operator-sdk\": executable file not found in $PATH" result=ERROR

Note

Since this is in the Scorecard method, it does not matter which check Basic or OlmSuite gets called, this error will appear.

• Relates: preflight fails on "operator-sdk scorecard: unexpected end of JSON input" #1203

[openshift-ci]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: acornett21

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [acornett21]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[dcibot]

from change #1209:

• FAILURE https://www.distributed-ci.io/jobs/698db206-ca98-4e7c-90ab-0d3e4a6a706b/jobStates

[dcibot]

from change #1209:

• SUCCESS https://www.distributed-ci.io/jobs/c39af2d0-0a5d-44c5-bce8-bf786b18dd06/jobStates