Update new elastic search request #105
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
sarathbrp
commented
Jan 10, 2024
sarathbrp
commented
- Added verification is set to False since new elastic search uses https
- And while making requests it uses authentication header where it fetches key from Jenkins pipeline
added verification false for https
jhutar
reviewed
Jan 11, 2024
| @@ -6,7 +6,7 @@ | |||
|
|
|||
|
|
|||
| session = requests.Session() | |||
|
|
|||
| session.verify=False | |||
There was a problem hiding this comment.
Hello Sarath. This is a generic library. Do not do changes like this here.
jhutar
reviewed
Jan 11, 2024
|
|
||
| import opl.http | ||
| import opl.status_data | ||
|
|
||
| # Environment variables for OpenSearch credentials | ||
| open_search_username = "insights_perf" |
There was a problem hiding this comment.
Please do not hardcode stuff here. This should come from investigator config.
jhutar
reviewed
Jan 11, 2024
|
|
||
| import opl.http | ||
| import opl.status_data | ||
|
|
||
| # Environment variables for OpenSearch credentials | ||
| open_search_username = "insights_perf" | ||
| open_search_password = os.environ.get('OPEN_SEARCH_PASSWORD') |
There was a problem hiding this comment.
I would add name of the variable to investigator config just to force user to understand it is needed.
jhutar
reviewed
Jan 11, 2024
| @@ -21,7 +26,7 @@ def load(server, index, query, paths): | |||
| f"Querying ES with url={url}, headers={headers} and json={json.dumps(data)}" | |||
| ) | |||
|
|
|||
| response = opl.http.get(url, headers=headers, json=data) | |||
| response = opl.http.get(url, auth=HTTPBasicAuth(open_search_username, open_search_password), headers=headers, json=data) | |||
There was a problem hiding this comment.
This is not backwards compatible. We will not be able to migrate all our tests at one moment. We need the change that will not break current setup.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.