Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(args): Add HBI DB args, fix typo in get_db_times #135

Closed
wants to merge 1 commit into from
Closed

feat(args): Add HBI DB args, fix typo in get_db_times #135

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions opl/args.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -86,6 +86,10 @@ def add_ros_db_opts(parser):
_add_generic_db_opts(parser, "ros")


def add_hbi_db_opts(parser):
_add_generic_db_opts(parser, "hbi")


Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello Jan. We already have add_inventory_db_opts(). This dual naming is annoying!

def add_kafka_opts(parser):
parser.add_argument(
"--kafka-host",
Expand Down
2 changes: 1 addition & 1 deletion opl/get_db_times.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -178,7 +178,7 @@ def _app_get_hosts(self, batch_hosts):
def work(self):
"""
1. Get host IDs from storage DB
2. Get timetamp from app DB
2. Get timestamp from app DB
3. Store timestamps in storage DB
4. Go to 1. until we have all hosts with their timestamps
"""
Expand Down
Loading