Upload Comparison result using multiple decision type #96
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Riya <rriya@redhat.com>
jhutar
reviewed
Oct 19, 2023
opl/investigator/config.py
Outdated
| @@ -90,3 +90,12 @@ def load_config(conf, fp): | |||
| conf.decisions_es_index = data["decisions"]["es_index"] | |||
| if conf.decisions_type == "csv": | |||
| conf.decisions_filename = data["decisions"]["filename"] | |||
|
|
|||
| decision_type = conf.decisions_type.split(",") | |||
There was a problem hiding this comment.
Can we maybe replace conf.decisions_type with the splited list so we do not have to split it every time we want to use it (e.g. in that opl/pass_or_fail.py)? Just to avoid duplicating that split and trip calls.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR #96
This PR deals with allowing multiple Decision types.
Earlier either we were able to get our results in the form of Decision.csv file or upload them to elasticsearch. With this change we will be able to gather results in csv format as well as send them to elasticsearch.