-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Statistics of defect severities 📊 #233
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
src/validation.sh
Outdated
echo -e "✋ ${YELLOW}Defects, NEEDS INSPECTION${NOCOLOR}" | ||
csgrep ../defects.log | ||
return 1 | ||
fi | ||
|
||
echo -e "🥳 ${GREEN}No defects added. Yay!${NOCOLOR}" | ||
} | ||
|
||
print_statistics () { | ||
echo -e "::group::📊 ${WHITE}Statistics${NOCOLOR}" |
Check warning
Code scanning / shellcheck
WHITE is referenced but not assigned. Warning
WHITE is referenced but not assigned.
jamacku
force-pushed
the
statistics
branch
2 times, most recently
from
August 10, 2023 15:17
9624cf7
to
59c44a3
Compare
jamacku
force-pushed
the
statistics
branch
3 times, most recently
from
August 11, 2023 11:09
62a0e45
to
120a1bc
Compare
Codecov Report
@@ Coverage Diff @@
## main #233 +/- ##
==========================================
+ Coverage 82.84% 83.70% +0.85%
==========================================
Files 4 4
Lines 239 270 +31
==========================================
+ Hits 198 226 +28
- Misses 41 44 +3
|
jamacku
force-pushed
the
statistics
branch
2 times, most recently
from
August 11, 2023 13:10
0ce855e
to
844a257
Compare
example of output: ```sh 📊 Statistics of defects Error: 0 Warning: 1 Note: 0 Style: 0 ```
Example output: ```md | | 👕 Style | 🗒️ Note |⚠️ Warning | 🛑 Error | |:--------:|:--------:|:-------:|:----------:|:--------:| | 🔢 Count | **N/A** | **N/A** | **10** | **0** | ```
- `print_statistics()` - `gather_statistics()` - `get_number_of_defects_by_severity()` - `summary_defect_statistics()`
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Let's add statistics about the type and count of new defects.
Example of statistics in console output for
severity: warning
:Example of statistics in job summary output for
severity: warning
: