Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

drop: shell-scripts input 🚫 #288

Merged
merged 2 commits into from
Aug 9, 2023

Conversation

jamacku
Copy link
Member

@jamacku jamacku commented Aug 9, 2023

No description provided.

@jamacku jamacku added the type: breaking Backwards incompatible change label Aug 9, 2023
@jamacku jamacku self-assigned this Aug 9, 2023
@jamacku jamacku modified the milestone: v4.3.0 Aug 9, 2023
@codecov
Copy link

codecov bot commented Aug 9, 2023

Codecov Report

Merging #288 (aabb7d2) into main (2932b05) will decrease coverage by 0.51%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main     #288      +/-   ##
==========================================
- Coverage   83.58%   83.07%   -0.51%     
==========================================
  Files           4        4              
  Lines         268      260       -8     
==========================================
- Hits          224      216       -8     
  Misses         44       44              
Files Changed Coverage Δ
src/functions.sh 84.10% <ø> (-0.80%) ⬇️

`shell-scripts` input was implemented initially as the only way to identify
shell scripts for scanning. Since then, Differential ShellCheck evolved,
and it can now detect shell scripts automatically.

Hence, `shell-scripts` will be removed in the next version.

Fixes: redhat-plumbers-in-action#287
@jamacku jamacku added this to the v5.0.0 milestone Aug 9, 2023
@jamacku jamacku marked this pull request as ready for review August 9, 2023 12:26
@jamacku jamacku merged commit 78322cb into redhat-plumbers-in-action:main Aug 9, 2023
9 checks passed
@jamacku jamacku deleted the drop-ignored-codes branch August 9, 2023 12:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[ANNOUNCEMENT]: input shell-scripts is going to be dropped in next release 🚫
1 participant