Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Drop support for DEBUG in grep 🐛 #322

Merged
merged 2 commits into from
Oct 4, 2023

Conversation

jamacku
Copy link
Member

@jamacku jamacku commented Oct 3, 2023

It doesn't work as expected. Also, the debug output is not very useful.

It fixes the issue when matched strings are outputted into the console:

#!/bin/bash
#!/bin/bash
#!/bin/bash
#!/bin/bash
#!/bin/bash
#!/bin/bash
#!/bin/bash


:::::::::::::::::::::
::: Used Versions :::
:::::::::::::::::::::

ShellCheck: 0.9.0
csutils: 3.0.4


:::::::::::::::::::::::::::::::
::: Differential ShellCheck :::
:::::::::::::::::::::::::::::::

📜 List of shell scripts for scanning

ℹ️ No Fixes!

🥳 No defects added. Yay!

✅ SARIF report was successfully uploaded to GitHub

@jamacku jamacku self-assigned this Oct 3, 2023
@mergify mergify bot added the source label Oct 3, 2023
@codecov
Copy link

codecov bot commented Oct 4, 2023

Codecov Report

Merging #322 (9536bc8) into main (c9cc531) will not change coverage.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##             main     #322   +/-   ##
=======================================
  Coverage   85.10%   85.10%           
=======================================
  Files           4        4           
  Lines         282      282           
=======================================
  Hits          240      240           
  Misses         42       42           
Files Coverage Δ
src/functions.sh 84.39% <100.00%> (ø)

It actually doesn't work as expected. Also the debug output is not very useful.
@jamacku jamacku merged commit 3dfdfcf into redhat-plumbers-in-action:main Oct 4, 2023
9 checks passed
@jamacku jamacku deleted the drop-debug-grep branch October 4, 2023 11:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant