Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve shell script detection based on emacs file mode header 🐯 #357

Merged
merged 2 commits into from
Feb 27, 2024

Conversation

jamacku
Copy link
Member

@jamacku jamacku commented Feb 27, 2024

  • add support for headers with mode: - e.g. -*- mode: sh -*-
  • add support for headers with shell script key

@jamacku jamacku added the type: feature New feature label Feb 27, 2024
@jamacku jamacku self-assigned this Feb 27, 2024
@jamacku jamacku linked an issue Feb 27, 2024 that may be closed by this pull request
Copy link

codecov bot commented Feb 27, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 85.10%. Comparing base (5580924) to head (2cab78d).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #357   +/-   ##
=======================================
  Coverage   85.10%   85.10%           
=======================================
  Files           4        4           
  Lines         282      282           
=======================================
  Hits          240      240           
  Misses         42       42           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jamacku jamacku merged commit c74f4ed into redhat-plumbers-in-action:main Feb 27, 2024
9 checks passed
@jamacku jamacku deleted the bash-comp branch February 27, 2024 13:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Scan files with -*- shell-script -*- annotation
1 participant