Fix curl Argument list too long by using a payload.json file #376
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #376 +/- ##
==========================================
- Coverage 85.10% 84.80% -0.31%
==========================================
Files 4 4
Lines 282 283 +1
==========================================
Hits 240 240
- Misses 42 43 +1 ☔ View full report in Codecov by Sentry. |
jamacku
approved these changes
Apr 26, 2024
There was a problem hiding this comment.
This is great. Thank you for contributing! 🚀
I also plan to remove whitespace from SARIF, as you have mentioned in #375 (comment)
kdudka
pushed a commit
to kdudka/csdiff
that referenced
this pull request
Apr 26, 2024
... taken from a real-world example encountered by differential-shellcheck: redhat-plumbers-in-action/differential-shellcheck#376 Related: csutils#98 Closes: csutils#168
kdudka
pushed a commit
to kdudka/csdiff
that referenced
this pull request
May 2, 2024
... taken from a real-world example encountered by differential-shellcheck: redhat-plumbers-in-action/differential-shellcheck#376 Related: csutils#98 Closes: csutils#168
kdudka
pushed a commit
to kdudka/csdiff
that referenced
this pull request
May 3, 2024
... taken from a real-world example encountered by differential-shellcheck: redhat-plumbers-in-action/differential-shellcheck#376 Related: csutils#98 Closes: csutils#168
kdudka
pushed a commit
to kdudka/csdiff
that referenced
this pull request
May 3, 2024
... taken from a real-world example encountered by differential-shellcheck: redhat-plumbers-in-action/differential-shellcheck#376 Related: csutils#98
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Should fix #375.
Tested by uploading the payload via curl to an httpd server using
curl -d '<json string>', which failed, and by using the payload.json which succeded. Also tested from the docker image.