Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Embed code context into SARIF output 🐾 #399

Merged
merged 1 commit into from
May 3, 2024

Conversation

jamacku
Copy link
Member

@jamacku jamacku commented May 3, 2024

This is preparation for Fingerprints, which are coming in the next version of csdiff.

It hashes the data that csdiff uses in its matching algorithm
and the line content without spaces. For this fingerprint to
be computed, the results need to include the line content for
the key event in the format produced by csgrep --embed-context.

This is preparation for Fingerprints that are coming in next version of csdiff.

csutils/csdiff#168

> It hashes the data that csdiff uses in its matching algorithm
> and the line content without spaces. For this fingerprint to
> be computed, the results need to include the line content for
> the key event in the format produced by `csgrep --embed-context`.
@jamacku jamacku added the type: feature New feature label May 3, 2024
@mergify mergify bot added the source label May 3, 2024
@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 84.96%. Comparing base (d33b5fa) to head (b894549).

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #399   +/-   ##
=======================================
  Coverage   84.96%   84.96%           
=======================================
  Files           4        4           
  Lines         286      286           
=======================================
  Hits          243      243           
  Misses         43       43           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jamacku jamacku merged commit ddda960 into redhat-plumbers-in-action:main May 3, 2024
7 checks passed
@jamacku jamacku deleted the context branch May 3, 2024 07:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants