Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support functions for future CLI ⚡ #405

Merged
merged 2 commits into from
May 7, 2024

Conversation

jamacku
Copy link
Member

@jamacku jamacku commented May 7, 2024

No description provided.

@@ -5,6 +5,8 @@

# shellcheck source=functions.sh
. "${SCRIPT_DIR="${CURRENT_DIR}/"}functions.sh"
# shellcheck source=setup.sh
. "${SCRIPT_DIR=}setup.sh"

Check warning

Code scanning / shellcheck

SC1091 Warning

Not following: setup.sh: openBinaryFile: does not exist (No such file or directory)
@codecov-commenter
Copy link

Codecov Report

Attention: Patch coverage is 71.42857% with 2 lines in your changes are missing coverage. Please review.

Project coverage is 84.40%. Comparing base (227e162) to head (5b1f542).
Report is 3 commits behind head on main.

Files Patch % Lines
src/functions.sh 66.66% 1 Missing ⚠️
src/setup.sh 66.66% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #405      +/-   ##
==========================================
- Coverage   84.72%   84.40%   -0.32%     
==========================================
  Files           4        5       +1     
  Lines         288      295       +7     
==========================================
+ Hits          244      249       +5     
- Misses         44       46       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jamacku jamacku merged commit beaa0a1 into redhat-plumbers-in-action:main May 7, 2024
6 of 7 checks passed
@jamacku jamacku deleted the support-fn branch May 7, 2024 14:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants