Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make operator-sdk job work again #141

Merged
merged 1 commit into from
Jan 22, 2024
Merged

Make operator-sdk job work again #141

merged 1 commit into from
Jan 22, 2024

Conversation

tkrishtop
Copy link
Contributor

@tkrishtop tkrishtop commented Jan 19, 2024 •
edited
Loading

TestDallasWorkload: operator-sdk

@tkrishtop tkrishtop requested a review from a team as a code owner January 19, 2024 14:44
@dcibot
Copy link
Collaborator

dcibot commented Jan 19, 2024

Starting dci-check-change job.

@tkrishtop
Copy link
Contributor Author

check workload operator-sdk

@softwarefactory-project-zuul softwarefactory-project-zuul
Copy link

Build succeeded.
https://softwarefactory-project.io/zuul/t/local/buildset/272d02665558497d82b5e81c497ad3e9

✔️ dci-rpm-build-el8 SUCCESS in 3m 27s
✔️ dci-rpm-build-el9 SUCCESS in 3m 14s

@tkrishtop
Copy link
Contributor Author

tkrishtop commented Jan 19, 2024 •
edited
Loading

@thekad Jorge, why did we change from shell to command everywhere? We are facing a situation where the parsing of multiline commands does not work as intended because of &&. The straightforward solution is to revert this task from command back to shell. Would that be acceptable, or should we avoid using shell for some other reasons?

@tkrishtop tkrishtop marked this pull request as draft January 19, 2024 15:00
@tkrishtop tkrishtop changed the title [DNM] Change command by shell to fix operator-sdk image build [DNM] Change command to shell to fix operator-sdk image build Jan 19, 2024
@dcibot
Copy link
Collaborator

dcibot commented Jan 19, 2024

@dcibot dcibot mentioned this pull request Jan 19, 2024
Closed
@tkrishtop
Copy link
Contributor Author

check workload operator-sdk

@tkrishtop tkrishtop changed the title [DNM] Change command to shell to fix operator-sdk image build Make operator-sdk job work again Jan 19, 2024
@dcibot
Copy link
Collaborator

dcibot commented Jan 19, 2024

Starting dci-check-change job.

@dcibot
Copy link
Collaborator

dcibot commented Jan 19, 2024

@dcibot
Copy link
Collaborator

dcibot commented Jan 19, 2024

Starting dci-check-change job.

@dcibot
Copy link
Collaborator

dcibot commented Jan 19, 2024

from change #141:

@dcibot
Copy link
Collaborator

dcibot commented Jan 19, 2024

@tkrishtop
Copy link
Contributor Author

check workload operator-sdk

@dcibot
Copy link
Collaborator

dcibot commented Jan 19, 2024

from change #141:

@tkrishtop
Copy link
Contributor Author

recheck

@tkrishtop tkrishtop marked this pull request as ready for review January 22, 2024 14:42
@tkrishtop
Copy link
Contributor Author

Tested green: https://www.distributed-ci.io/jobs/1f6979f2-cdf8-4486-a25d-929aa2b0455d/tests
Would appreciate a review

@softwarefactory-project-zuul softwarefactory-project-zuul
Copy link

Build succeeded.
https://softwarefactory-project.io/zuul/t/local/buildset/29bdce5115e04d2e88d59f95c49c3b41

✔️ dci-rpm-build-el8 SUCCESS in 3m 28s
✔️ dci-rpm-build-el9 SUCCESS in 2m 59s

@dcibot
Copy link
Collaborator

dcibot commented Jan 22, 2024

from change #141:

@tkrishtop
Copy link
Contributor Author

@fredericlepied could you please approuve? that's a command -> shell fix for the operatot-sdk job that we have discussed

@tkrishtop tkrishtop added this pull request to the merge queue Jan 22, 2024
Merged via the queue into main with commit a36c348 Jan 22, 2024
7 checks passed
@tkrishtop tkrishtop deleted the operator_sdk_tests branch January 22, 2024 16:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fredericlepied fredericlepied fredericlepied approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@tkrishtop @dcibot @fredericlepied