Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rename oc_setup role into ocp_add_users #467

Open
wants to merge 9 commits into
base: main
Choose a base branch
from
Open

Rename oc_setup role into ocp_add_users #467

wants to merge 9 commits into from
+272 −151

Conversation

tonyskapunk
Copy link
Contributor

@tonyskapunk tonyskapunk commented Oct 16, 2024 •
edited
Loading

SUMMARY

The new role is less rigid on the creation of users, allowing to create more or less, or append users when other users already exist.

ISSUE TYPE
  • Enhanced Feature
Tests

Test-Hints: no-check

@tonyskapunk
Rename oc_setup role into ocp_add_users
2755b96 
The new role is less rigid on the creation of users, allowing to create
more or less, or append users when other users already exist.
@tonyskapunk tonyskapunk requested review from a team as code owners October 16, 2024 19:34
@dcibot
Copy link
Collaborator

dcibot commented Oct 16, 2024

from change #467:

  • no check (not a code change)

1 similar comment
@dcibot
Copy link
Collaborator

dcibot commented Oct 16, 2024

from change #467:

  • no check (not a code change)

@tonyskapunk tonyskapunk marked this pull request as draft October 16, 2024 19:34
@tonyskapunk
Copy link
Contributor Author

retest

@softwarefactory-project-zuul softwarefactory-project-zuul
Copy link

Build succeeded.
https://softwarefactory-project.io/zuul/t/local/buildset/8d75720ef74e4edb91c64f84ab92bf33

✔️ dci-rpm-build-el8 SUCCESS in 2m 44s
✔️ dci-rpm-build-el9 SUCCESS in 2m 18s

thekad
thekad reviewed Oct 16, 2024
View reviewed changes
roles/ocp_add_users/README.md Show resolved Hide resolved
roles/ocp_add_users/README.md Show resolved Hide resolved
roles/ocp_add_users/tasks/add-users.yml Show resolved Hide resolved
@dcibot
Copy link
Collaborator

dcibot commented Oct 16, 2024

from change #467:

@tonyskapunk tonyskapunk self-assigned this Oct 16, 2024
@softwarefactory-project-zuul softwarefactory-project-zuul
Copy link

Build succeeded.
https://softwarefactory-project.io/zuul/t/local/buildset/b910b25daa2d4780888efe9c97c50ca3

✔️ dci-rpm-build-el8 SUCCESS in 2m 43s
✔️ dci-rpm-build-el9 SUCCESS in 2m 27s

@tonyskapunk
Copy link
Contributor Author

retest

@dcibot
Copy link
Collaborator

dcibot commented Oct 16, 2024

from change #467:

@tonyskapunk
Copy link
Contributor Author

retest

@dcibot
Copy link
Collaborator

dcibot commented Oct 16, 2024

from change #467:

@tonyskapunk
Copy link
Contributor Author

retest

@dcibot
Copy link
Collaborator

dcibot commented Oct 17, 2024

from change #467:

@softwarefactory-project-zuul softwarefactory-project-zuul
Copy link

Build succeeded.
https://softwarefactory-project.io/zuul/t/local/buildset/0d9ab21a572147919f664f4aa521d55f

✔️ dci-rpm-build-el8 SUCCESS in 2m 43s
✔️ dci-rpm-build-el9 SUCCESS in 2m 29s

@dcibot
Copy link
Collaborator

dcibot commented Oct 17, 2024

from change #467:

@softwarefactory-project-zuul softwarefactory-project-zuul
Copy link

Build succeeded.
https://softwarefactory-project.io/zuul/t/local/buildset/c7901bd963994d39a3924029419d8214

✔️ dci-rpm-build-el8 SUCCESS in 2m 54s
✔️ dci-rpm-build-el9 SUCCESS in 2m 32s

@dcibot
Copy link
Collaborator

dcibot commented Oct 17, 2024

from change #467:

@softwarefactory-project-zuul softwarefactory-project-zuul
Copy link

Build succeeded.
https://softwarefactory-project.io/zuul/t/local/buildset/152c09252ed248d6838a31c6d807f3ad

✔️ dci-rpm-build-el8 SUCCESS in 2m 44s
✔️ dci-rpm-build-el9 SUCCESS in 2m 29s

@dcibot
Copy link
Collaborator

dcibot commented Oct 17, 2024

from change #467:

@softwarefactory-project-zuul softwarefactory-project-zuul
Copy link

Build succeeded.
https://softwarefactory-project.io/zuul/t/local/buildset/929399e991f44805a53ae5e0a9dbcb1e

✔️ dci-rpm-build-el8 SUCCESS in 2m 52s
✔️ dci-rpm-build-el9 SUCCESS in 2m 29s

@dcibot
Copy link
Collaborator

dcibot commented Oct 17, 2024

from change #467:

@softwarefactory-project-zuul softwarefactory-project-zuul
Copy link

Build succeeded.
https://softwarefactory-project.io/zuul/t/local/buildset/6896a157704541c7a17e82c77e11b8aa

✔️ dci-rpm-build-el8 SUCCESS in 2m 45s
✔️ dci-rpm-build-el9 SUCCESS in 2m 20s

@dcibot
Copy link
Collaborator

dcibot commented Oct 17, 2024

from change #467:

@tonyskapunk
Copy link
Contributor Author

retest

@dcibot
Copy link
Collaborator

dcibot commented Oct 18, 2024

from change #467:

ramperher
ramperher previously approved these changes Oct 18, 2024
View reviewed changes
Copy link
Contributor

@ramperher ramperher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, I saw the test cases are passing and the code structure looks good to me too.

@dcibot
Copy link
Collaborator

dcibot commented Oct 18, 2024

from change #467:

  • no check (not a code change)

1 similar comment
@dcibot
Copy link
Collaborator

dcibot commented Oct 18, 2024

from change #467:

  • no check (not a code change)

@softwarefactory-project-zuul softwarefactory-project-zuul
Copy link

Build succeeded.
https://softwarefactory-project.io/zuul/t/local/buildset/a6cd625566804e00828621c73f41aa1c

✔️ dci-rpm-build-el8 SUCCESS in 2m 46s
✔️ dci-rpm-build-el9 SUCCESS in 2m 25s

@dcibot
Copy link
Collaborator

dcibot commented Oct 18, 2024

from change https://github.com/dci-labs/dallas-config/pull/165:

betoredhat
betoredhat previously approved these changes Oct 18, 2024
View reviewed changes
Copy link
Contributor

@betoredhat betoredhat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm 💯

@dcibot
Copy link
Collaborator

dcibot commented Oct 18, 2024

from change https://github.com/dci-labs/dallas-config/pull/165:

@tonyskapunk tonyskapunk marked this pull request as ready for review October 18, 2024 21:50
@tonyskapunk
Copy link
Contributor Author

Another validation is currently undergoing it is to test that it can append users to already created users. Expecting a successful job.

@dcibot
Copy link
Collaborator

dcibot commented Oct 18, 2024

from change https://github.com/dci-labs/dallas-config/pull/165:

@tonyskapunk
Copy link
Contributor Author

retest

@dcibot
Copy link
Collaborator

dcibot commented Oct 19, 2024

from change #467:

  • no check (not a code change)

1 similar comment
@dcibot
Copy link
Collaborator

dcibot commented Oct 19, 2024

from change #467:

  • no check (not a code change)

@dcibot
Copy link
Collaborator

dcibot commented Oct 19, 2024

from change #467:

  • no check (not a code change)

1 similar comment
@dcibot
Copy link
Collaborator

dcibot commented Oct 19, 2024

from change #467:

  • no check (not a code change)

@softwarefactory-project-zuul softwarefactory-project-zuul
Copy link

Build succeeded.
https://softwarefactory-project.io/zuul/t/local/buildset/8a3b240d37774d49a87b73c67887c98e

✔️ dci-rpm-build-el8 SUCCESS in 2m 44s
✔️ dci-rpm-build-el9 SUCCESS in 2m 23s

tonyskapunk
tonyskapunk commented Oct 19, 2024
View reviewed changes
ansible-collection-redhatci-ocp.spec
@@ -28,6 +28,7 @@ Requires: python3-jmespath
Requires: python3-netaddr
Requires: python3-pyyaml
Requires: skopeo
Conflicts: dci-openshift-agent < 0.23.0
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ramperher ramperher ramperher left review comments

@betoredhat betoredhat betoredhat left review comments

@thekad thekad Awaiting requested review from thekad

At least 1 approving review is required to merge this pull request.

Assignees

@tonyskapunk tonyskapunk

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@tonyskapunk @dcibot @thekad @ramperher @betoredhat @fredericlepied