Adding sushy tools to the ocp-on-libvirt solution #9

nsilla · 2023-10-16T09:44:00Z

Currently ocp-on-libvirt installs the conserver service along with the VMs to allow for IPMI remote management of the hosts, which in turn allows for PXE image boot up.

In order to support ZTP deployments, virtual media image boot up is needed, and to manage it remotely, the target server BMCs must suport the redfish protocol.

Sushy tools provides support for the redfish protocol for libvirt VMs.

This change installs sushy tools, as implemented in the assisted-installer ansible project, when running the ocp-on-libvirt role.

Build-Depends: 28766
Build-Depends: https://github.com/dci-labs/bos2-ci-config/pull/93
Test-Args-Hints: -e enable_redfish=true -e enable_virtualmedia=true

dcibot · 2023-10-16T10:06:26Z

Starting dci-check-change job.

dcibot · 2023-10-16T10:15:24Z

dci-check-change : FAILURE tested on libvirt:virt
libvirt -> error: https://www.distributed-ci.io/jobs/f0c7757f-7be2-4d25-9899-cc9382fdb687/jobStates

dcibot · 2023-10-16T10:29:26Z

Starting dci-check-change job.

dcibot · 2023-10-16T10:38:03Z

dci-check-change : FAILURE tested on libvirt:virt
libvirt -> error: https://www.distributed-ci.io/jobs/05a4b415-9684-4b9b-92ad-19c0c5592dc0/jobStates

dcibot · 2023-10-16T10:47:26Z

Starting dci-check-change job.

dcibot · 2023-10-16T10:56:14Z

dci-check-change : FAILURE tested on libvirt:virt
libvirt -> error: https://www.distributed-ci.io/jobs/d79a5f2c-5a3b-41c0-adee-f19104f78c0d/jobStates

dcibot · 2023-10-16T11:11:27Z

Starting dci-check-change job.

dcibot · 2023-10-16T11:20:07Z

dci-check-change : FAILURE tested on libvirt:virt
libvirt -> error: https://www.distributed-ci.io/jobs/42e429b8-6bc6-4fcd-83fe-a6601770af6b/jobStates

dcibot · 2023-10-16T12:03:26Z

Starting dci-check-change job.

dcibot · 2023-10-16T12:12:14Z

dci-check-change : FAILURE tested on libvirt:virt
libvirt -> error: https://www.distributed-ci.io/jobs/a71e50ae-182f-453e-8927-f7d428442853/jobStates

dcibot · 2023-10-16T12:29:26Z

Starting dci-check-change job.

dcibot · 2023-10-16T12:29:33Z

dci-check-change preparation : FAILURE tested on libvirt:virt

dcibot · 2023-10-16T12:37:22Z

Starting dci-check-change job.

dcibot · 2023-10-16T12:37:28Z

dci-check-change preparation : FAILURE tested on libvirt:virt

dcibot · 2023-10-16T12:41:22Z

Starting dci-check-change job.

dcibot · 2023-10-16T12:41:30Z

dci-check-change preparation : FAILURE tested on libvirt:virt

dcibot · 2023-10-16T13:18:25Z

Starting dci-check-change job.

dcibot · 2023-10-16T13:18:32Z

dci-check-change preparation : FAILURE tested on libvirt:virt

dcibot · 2023-10-18T10:05:22Z

ERROR unable to rebase PR 9 from redhatci/ansible-collection-redhatci-ocp branch main

dcibot · 2023-10-18T10:07:04Z

ERROR unable to rebase PR 9 from redhatci/ansible-collection-redhatci-ocp branch main

dcibot · 2023-10-18T10:15:13Z

ERROR unable to rebase PR 9 from redhatci/ansible-collection-redhatci-ocp branch main

dcibot · 2023-10-18T10:30:30Z

Starting dci-check-change job.

dcibot · 2023-10-18T12:03:47Z

dci-check-change : SUCCESS tested on libvirt:virt
libvirt -> success: https://www.distributed-ci.io/jobs/7872750e-2ee0-4444-893d-3ace37cc8dee/jobStates
control_plane_example -> success: https://www.distributed-ci.io/jobs/7006f870-a3a7-46b2-b10c-48759b9327d7/jobStates

dcibot · 2023-10-24T09:01:30Z

Starting dci-check-change job.

dcibot · 2023-10-24T10:05:34Z

dci-check-change preparation : FAILURE tested on libvirt:virt

dcibot · 2023-10-24T10:13:26Z

Starting dci-check-change job.

dcibot · 2023-10-24T10:25:07Z

dci-check-change preparation : KILLED tested on libvirt:virt

PR squashed and rebased as requested

dcibot · 2024-04-09T13:57:00Z

Starting dci-check-change job.

dcibot · 2024-04-09T14:06:23Z

dci-check-change : FAILURE tested on libvirt:virt
libvirt -> error: https://www.distributed-ci.io/jobs/9823df16-34b6-49fb-9cad-65a66d6bda9a/jobStates

dcibot · 2024-04-11T09:58:59Z

Starting dci-check-change job.

dcibot · 2024-04-11T12:13:28Z

dci-check-change : SUCCESS tested on libvirt:virt
libvirt -> success: https://www.distributed-ci.io/jobs/6a640866-fe3e-46f7-853a-42994e7f46d8/jobStates
control_plane_example -> success: https://www.distributed-ci.io/jobs/21849c4e-96bf-419a-a887-ddf8e6d0883a/jobStates

dcibot · 2024-04-11T12:54:01Z

Starting dci-check-change job.

dcibot · 2024-04-11T14:59:37Z

dci-check-change : SUCCESS tested on libvirt:virt
libvirt -> success: https://www.distributed-ci.io/jobs/f4c1af30-96ab-4c7e-934f-224a8da27967/jobStates
control_plane_example -> success: https://www.distributed-ci.io/jobs/eb9d2491-0c5d-4840-a299-30a1608246e1/jobStates

nsilla · 2024-04-12T07:24:24Z

recheck

softwarefactory-project-zuul · 2024-04-12T07:28:24Z

Build succeeded.
https://softwarefactory-project.io/zuul/t/local/buildset/9f90a00de53b477097e48e2a3b1e0dde

✔️ dci-rpm-build-el8 SUCCESS in 3m 33s
✔️ dci-rpm-build-el9 SUCCESS in 3m 36s

softwarefactory-project-zuul · 2024-04-12T08:17:21Z

Build succeeded.
https://softwarefactory-project.io/zuul/t/local/buildset/2ab65cfe58f9411aa73b5f92c92c6f9f

✔️ dci-rpm-build-el8 SUCCESS in 3m 48s
✔️ dci-rpm-build-el9 SUCCESS in 3m 52s

dcibot · 2024-04-12T08:18:02Z

Starting dci-check-change job.

dcibot · 2024-04-12T10:08:45Z

dci-check-change : SUCCESS tested on libvirt:virt
libvirt -> success: https://www.distributed-ci.io/jobs/e430941a-622d-44bf-a269-4f728bcdf838/jobStates
control_plane_example -> success: https://www.distributed-ci.io/jobs/87c06230-600f-4f01-b62b-c369100851d6/jobStates

tonyskapunk · 2024-04-15T13:55:03Z

roles/ocp_on_libvirt/README.md

+ocp_on_libvirt_cert_locality            | No        | Westford | see *cert_country*
+ocp_on_libvirt_cert_organization        | No        | DCI      | see *cert_country*
+ocp_on_libvirt_cert_organizational_unit | No        | Lab      | see *cert_country*
+sushy_ignore_boot_device                | No        | false    | When deploying the sushy-tools redfish emulator, set to "true" to instruct the libvirt driver to ignore any instructions to set the boot device.


could we name this one with ocp_on_libvirt_ prefix? The reasoning is because this is the same variable used in setup_sushy_tools role. See my other comment when using that role

roles/ocp_on_libvirt/tasks/redfish_setup.yml

Currently ocp-on-libvirt installs the vBMC service along with the VMs to allow for IPMI remote management of the hosts, which in turn allows for PXE image boot up. In order to support ACM managed deployments, virtual media image boot up is needed, and to manage it remotely, the target server BMCs must suport the Redfish protocol. Sushy tools provides support for the Redfish protocol for libvirt VMs. This change installs sushy tools, as implemented for assisted-installer based deployments, when running the ocp-on-libvirt role.

softwarefactory-project-zuul · 2024-04-16T08:12:35Z

Build succeeded.
https://softwarefactory-project.io/zuul/t/local/buildset/5096443d6e654c1c9dc6f6a25b03ef00

✔️ dci-rpm-build-el8 SUCCESS in 3m 16s
✔️ dci-rpm-build-el9 SUCCESS in 3m 44s

dcibot · 2024-04-16T08:13:02Z

Starting dci-check-change job.

dcibot · 2024-04-16T08:16:00Z

Starting dci-check-change job.

dcibot · 2024-04-16T10:03:58Z

dci-check-change : SUCCESS tested on libvirt:virt
libvirt -> success: https://www.distributed-ci.io/jobs/8d431ca7-222c-4091-a852-4c982581cff0/jobStates
control_plane_example -> success: https://www.distributed-ci.io/jobs/12a1499f-ad54-46f0-bea8-8ea6e76731bc/jobStates

dcibot · 2024-04-16T10:22:50Z

dci-check-change : SUCCESS tested on libvirt:virt
libvirt -> success: https://www.distributed-ci.io/jobs/f800e8d2-4945-4239-b1c8-b4394dda30ae/jobStates
control_plane_example -> success: https://www.distributed-ci.io/jobs/eec88cf0-cb97-49ce-9ba8-f5fb6b148680/jobStates

tonyskapunk

LGTM

Thanks for all the effort and the work put in this!

dcibot · 2024-04-17T05:48:02Z

Starting dci-check-change job.

dcibot · 2024-04-17T05:56:40Z

dci-check-change preparation : KILLED tested on libvirt:virt

nsilla force-pushed the sushy-tools_ocp-on-libvirt branch from cac091b to 068dfa1 Compare October 16, 2023 12:26

nsilla force-pushed the sushy-tools_ocp-on-libvirt branch from 068dfa1 to e8210ef Compare October 18, 2023 10:13

nsilla force-pushed the sushy-tools_ocp-on-libvirt branch from e8210ef to c470ee4 Compare October 18, 2023 10:27

nsilla force-pushed the sushy-tools_ocp-on-libvirt branch from ee2c5b8 to cacb0e4 Compare April 12, 2024 08:13

tonyskapunk reviewed Apr 15, 2024

View reviewed changes

nsilla force-pushed the sushy-tools_ocp-on-libvirt branch from cacb0e4 to f618b7a Compare April 16, 2024 08:08

nsilla requested a review from tonyskapunk April 16, 2024 08:12

tonyskapunk approved these changes Apr 16, 2024

View reviewed changes

nocturnalastro approved these changes Apr 16, 2024

View reviewed changes

nsilla added this pull request to the merge queue Apr 16, 2024

Merged via the queue into redhatci:main with commit e63dbd2 Apr 16, 2024
8 checks passed

nsilla deleted the sushy-tools_ocp-on-libvirt branch April 16, 2024 15:40

Adding sushy tools to the ocp-on-libvirt solution #9

Adding sushy tools to the ocp-on-libvirt solution #9

Conversation

nsilla commented Oct 16, 2023 • edited Loading

dcibot commented Oct 16, 2023

dcibot commented Oct 16, 2023

dcibot commented Oct 16, 2023

dcibot commented Oct 16, 2023

dcibot commented Oct 16, 2023

dcibot commented Oct 16, 2023

dcibot commented Oct 16, 2023

dcibot commented Oct 16, 2023

dcibot commented Oct 16, 2023

dcibot commented Oct 16, 2023

dcibot commented Oct 16, 2023

dcibot commented Oct 16, 2023

dcibot commented Oct 16, 2023

dcibot commented Oct 16, 2023

dcibot commented Oct 16, 2023

dcibot commented Oct 16, 2023

dcibot commented Oct 16, 2023

dcibot commented Oct 16, 2023

dcibot commented Oct 18, 2023

dcibot commented Oct 18, 2023

dcibot commented Oct 18, 2023

dcibot commented Oct 18, 2023

dcibot commented Oct 18, 2023

dcibot commented Oct 24, 2023

dcibot commented Oct 24, 2023

dcibot commented Oct 24, 2023

dcibot commented Oct 24, 2023

dcibot commented Apr 9, 2024

dcibot commented Apr 9, 2024

dcibot commented Apr 11, 2024

dcibot commented Apr 11, 2024

dcibot commented Apr 11, 2024

dcibot commented Apr 11, 2024

nsilla commented Apr 12, 2024

softwarefactory-project-zuul bot commented Apr 12, 2024

softwarefactory-project-zuul bot commented Apr 12, 2024

dcibot commented Apr 12, 2024

dcibot commented Apr 12, 2024

tonyskapunk Apr 15, 2024

Choose a reason for hiding this comment

softwarefactory-project-zuul bot commented Apr 16, 2024

dcibot commented Apr 16, 2024

dcibot commented Apr 16, 2024

dcibot commented Apr 16, 2024

dcibot commented Apr 16, 2024

tonyskapunk left a comment

Choose a reason for hiding this comment

dcibot commented Apr 17, 2024

dcibot commented Apr 17, 2024

nsilla commented Oct 16, 2023 •

edited

Loading