fix: set an ID option to a cluster config for the compatibility (#403)

redis-rb · Nov 14, 2024 · ff2969d · ff2969d
1 parent 415d91a
commit ff2969d
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 1 deletion.
diff --git a/lib/redis_client/cluster_config.rb b/lib/redis_client/cluster_config.rb
@@ -31,7 +31,7 @@ class ClusterConfig
     InvalidClientConfigError = Class.new(::RedisClient::Cluster::Error)
 
     attr_reader :command_builder, :client_config, :replica_affinity, :slow_command_timeout,
-                :connect_with_original_config, :startup_nodes, :max_startup_sample
+                :connect_with_original_config, :startup_nodes, :max_startup_sample, :id
 
     def initialize( # rubocop:disable Metrics/ParameterLists
       nodes: DEFAULT_NODES,
@@ -60,6 +60,7 @@ def initialize( # rubocop:disable Metrics/ParameterLists
       @client_implementation = client_implementation
       @slow_command_timeout = slow_command_timeout
       @max_startup_sample = max_startup_sample
+      @id = client_config[:id]
     end
 
     def inspect

diff --git a/test/redis_client/test_cluster_config.rb b/test/redis_client/test_cluster_config.rb
@@ -190,5 +190,10 @@ def test_client_config_for_node
                      custom: { foo: 'bar' }
                    }, config.client_config_for_node('9.9.9.9:9999'))
     end
+
+    def test_client_config_id
+      assert_equal('foo-cluster', ::RedisClient::ClusterConfig.new(id: 'foo-cluster').id)
+      assert_nil(::RedisClient::ClusterConfig.new.id)
+    end
   end
 end