Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: make some errors identifiable to which cluster related #401

Merged
merged 1 commit into from
Nov 14, 2024
Merged

fix: make some errors identifiable to which cluster related #401

merged 1 commit into from
Nov 14, 2024

Conversation

supercaracal
Copy link
Member

@supercaracal supercaracal commented Nov 14, 2024 •
edited
Loading

These changes may be useful in case of such needs to deal with multiple clusters or mixed-type redis instances in an application. This pull request includes the following modifications.

  • Our cluster-related errors inherit from RedisClient::Cluster::Error class.
    • RedisClient::Cluster::Error class inherits from RedisClient::Error class.
  • Our cluster-related errors bind a config intance specified at the client initialization.
    • Doing this make you able to distiguish what cluster has caused those errors.

@supercaracal supercaracal linked an issue Nov 14, 2024 that may be closed by this pull request
Possible to add a common error superclass for redis-cluster-client errors? Or use with_config consistently? #400
Closed
@supercaracal supercaracal marked this pull request as ready for review November 14, 2024 12:13
@supercaracal supercaracal merged commit f9e7410 into redis-rb:master Nov 14, 2024
33 checks passed
@supercaracal supercaracal deleted the fix-err-id branch November 14, 2024 12:13
@supercaracal supercaracal mentioned this pull request Nov 14, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Possible to add a common error superclass for redis-cluster-client errors? Or use with_config consistently?
1 participant
@supercaracal