Add CONTRIBUTING Guidelines #119
Conversation
|
@chayim LMK if something is missing or needs to be removed |
Codecov ReportPatch and project coverage have no change.
📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more Additional details and impacted files@@ Coverage Diff @@
## master #119 +/- ##
=======================================
Coverage 93.27% 93.27%
=======================================
Files 77 77
Lines 4582 4582
Branches 424 424
=======================================
Hits 4274 4274
Misses 186 186
Partials 122 122 ☔ View full report in Codecov by Sentry. |
CONTRIBUTING.md
Outdated
| 2. Do the changes in your fork | ||
| 3. Write your tests | ||
|
|
||
| 4. Use the `docker run -p 6379:6379 -it redis/redis-stack-server` as your local environment for running the functional tests. |
There was a problem hiding this comment.
docker run -p 6379:6379 -it redis/redis-stack-server:edge
CONTRIBUTING.md
Outdated
| dotnet test --filter <YourTestName> | ||
| ``` | ||
|
|
||
| If you want to run your tests against a specific host, you can do it this way: |
There was a problem hiding this comment.
If you want to run your tests against a specific host and port, you can do it thus:
|
@shacharPash Can you take @nermiller suggestions and apply them to redis-py when done? Given that we used that as a base, it seems like some of these improvements can make it there as well. Thanks @nermiller ❤️ |
Co-authored-by: Nermina Miller <102551568+nermiller@users.noreply.github.com>
Co-authored-by: Nermina Miller <102551568+nermiller@users.noreply.github.com>
Co-authored-by: Nermina Miller <102551568+nermiller@users.noreply.github.com>
Co-authored-by: Nermina Miller <102551568+nermiller@users.noreply.github.com>
Co-authored-by: Nermina Miller <102551568+nermiller@users.noreply.github.com>
Co-authored-by: Nermina Miller <102551568+nermiller@users.noreply.github.com>
Co-authored-by: Nermina Miller <102551568+nermiller@users.noreply.github.com>
Co-authored-by: Nermina Miller <102551568+nermiller@users.noreply.github.com>
Co-authored-by: Nermina Miller <102551568+nermiller@users.noreply.github.com>
Co-authored-by: Nermina Miller <102551568+nermiller@users.noreply.github.com>
Co-authored-by: Nermina Miller <102551568+nermiller@users.noreply.github.com>
Closes #118