Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(deps): Update otel/metric to stable API #2607

Merged
merged 1 commit into from
May 24, 2023
Merged

chore(deps): Update otel/metric to stable API #2607

merged 1 commit into from
May 24, 2023

Conversation

ash2k
Copy link
Contributor

@ash2k ash2k commented May 23, 2023

Pick up https://github.com/open-telemetry/opentelemetry-go/releases/tag/v1.16.0.

The example also needs to be updated, but uptrace-go needs to be updated first.

Closes #2578.

@vmihailenco
Copy link
Collaborator

vmihailenco commented May 23, 2023

Thanks! uptrace-go update is blocked by open-telemetry/opentelemetry-go-contrib#3874

@pellared
Copy link

pellared commented May 23, 2023

Are you not using uptrace-go only in OTel example?

Personally, I would suggest moving the example here: https://github.com/uptrace/uptrace-go/tree/master/example and change the existing example to use only the official "vanilla" OTel Go components.

PS. I am not a maintainer here. I just noticed this PR via open-telemetry/opentelemetry-go-contrib#3874 and I hope that this idea may help you. Feel free to ignore my comment for whatever reason 😉

@vmihailenco
Copy link
Collaborator

@ash2k uptrace-go is updated - could you update this PR?

Personally, I would suggest moving the example here

We had lots of examples in uptrace-go, but it was hard to update them and it resulted in a lot of noise in the repo for uptrace-go users.

Besides, the example here is in a separate module so it does not affect the redis client.

@ash2k
Copy link
Contributor Author

ash2k commented May 24, 2023

@vmihailenco PTAL

@vmihailenco vmihailenco merged commit 9a9423d into redis:master May 24, 2023
@ash2k ash2k deleted the update-otel branch May 24, 2023 10:40
@ash2k
Copy link
Contributor Author

ash2k commented May 24, 2023

@vmihailenco Any plans to release a new version soon? :)

@vmihailenco
Copy link
Collaborator

@ash2k #2608

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants